Change argument _self in _io/textio.c

[JeffreyArmstrong]

BPO	19356
Nosy	@pitrou, @tjguk, @briancurtin
Files	_self.3.3.2.patch: Patch to rename the argument _self to myself _ctypes._self.3.3.2.patch: Changes to _ctypes module _elementree._self.3.3.2.patch: Changes to _elementree module

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-10-23.17:22:33.124>
created_at = <Date 2013-10-23.02:05:01.889>
labels = ['build', 'expert-IO']
title = 'Change argument _self in _io/textio.c'
updated_at = <Date 2013-10-23.17:22:33.122>
user = 'https://bugs.python.org/JeffreyArmstrong'

bugs.python.org fields:

activity = <Date 2013-10-23.17:22:33.122>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2013-10-23.17:22:33.124>
closer = 'pitrou'
components = ['Build', 'IO']
creation = <Date 2013-10-23.02:05:01.889>
creator = 'Jeffrey.Armstrong'
dependencies = []
files = ['32308', '32311', '32312']
hgrepos = []
issue_num = 19356
keywords = ['patch']
message_count = 7.0
messages = ['200992', '201003', '201005', '201016', '201017', '201049', '201050']
nosy_count = 5.0
nosy_names = ['pitrou', 'tim.golden', 'brian.curtin', 'python-dev', 'Jeffrey.Armstrong']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue19356'
versions = ['Python 3.3', 'Python 3.4']

[JeffreyArmstrong]

At Modules/_io/textio.c:285, one argument to _PyIncrementalNewlineDecoder_decode is named "_self." The name "_self," however is a keyword on older Microsoft C compilers and certain other compilers attempting to maintain compatibility with Microsoft. Renaming the argument to "myself" would fix the problem with certain compilers (Microsoft C, Open Watcom, possibly more).

Please note that this is not an issue with MSVC.

[tjguk]

I don't feel strongly about this. However, ISTM that we work reasonably
hard to work with the vagaries of *nix toolchains so I don't see why an
unintrusive change like this shouldn't go in to support some corner
cases on the Windows front.

[pitrou]

I see other instances of _self in elementtree and ctypes. Don't you want to replace those too?

[JeffreyArmstrong]

That was sloppy of me to not check other modules. I hadn't encountered them in my build yet. Here's a patch for Modules/_ctypes/_ctypes.c and Modules/_ctypes/callbacks.c. The arguments were changed similarly to "myself."

[JeffreyArmstrong]

And finally here's the necessary changes to Modules/_elementree.c as well.

[python-dev]

New changeset 763af3d957f3 by Antoine Pitrou in branch '3.3':
Issue bpo-19356: Avoid using a C variabled named "_self", it's a reserved word in some C compilers.
http://hg.python.org/cpython/rev/763af3d957f3

New changeset f6430aec5bf2 by Antoine Pitrou in branch 'default':
Issue bpo-19356: Avoid using a C variabled named "_self", it's a reserved word in some C compilers.
http://hg.python.org/cpython/rev/f6430aec5bf2

[pitrou]

Thanks for the patches, they're committed now.