Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nturl2path test coverage #63582

Open
ColinWilliams mannequin opened this issue Oct 24, 2013 · 2 comments
Open

nturl2path test coverage #63582

ColinWilliams mannequin opened this issue Oct 24, 2013 · 2 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@ColinWilliams
Copy link
Mannequin

ColinWilliams mannequin commented Oct 24, 2013

BPO 19383
Nosy @orsenthil, @ezio-melotti
Files
  • nturl2path.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2013-10-24.23:33:34.720>
    labels = ['type-feature', 'tests']
    title = 'nturl2path test coverage'
    updated_at = <Date 2013-11-16.23:45:11.596>
    user = 'https://bugs.python.org/ColinWilliams'

    bugs.python.org fields:

    activity = <Date 2013-11-16.23:45:11.596>
    actor = 'ezio.melotti'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Tests']
    creation = <Date 2013-10-24.23:33:34.720>
    creator = 'Colin.Williams'
    dependencies = []
    files = ['32345']
    hgrepos = []
    issue_num = 19383
    keywords = ['patch']
    message_count = 2.0
    messages = ['201197', '203107']
    nosy_count = 3.0
    nosy_names = ['orsenthil', 'ezio.melotti', 'Colin.Williams']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue19383'
    versions = ['Python 3.4']

    @ColinWilliams
    Copy link
    Mannequin Author

    ColinWilliams mannequin commented Oct 24, 2013

    Full coverage on this module

    @berkerpeksag berkerpeksag added the tests Tests in the Lib/test dir label Oct 25, 2013
    @ezio-melotti
    Copy link
    Member

    The assertions have their arguments in the wrong order, it should be (actual, expected).
    In the code of the module there are also some examples in the comments, e.g.:
    # path is something like ////host/path/on/remote/host
    # convert this to \\host\path\on\remote\host
    Even though the path is covered, there's no similar test in this patch.
    I would suggest you to include all the examples from the module in the tests.

    Also note that this module is already indirectly tested in test_urllib.

    @ezio-melotti ezio-melotti added the type-feature A feature request or enhancement label Nov 16, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants