Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leak in _hashopenssl.c #63619

Closed
skrah mannequin opened this issue Oct 28, 2013 · 7 comments
Closed

Leak in _hashopenssl.c #63619

skrah mannequin opened this issue Oct 28, 2013 · 7 comments
Assignees
Labels
extension-modules C modules in the Modules dir performance Performance or resource usage

Comments

@skrah
Copy link
Mannequin

skrah mannequin commented Oct 28, 2013

BPO 19420
Nosy @pitrou, @tiran, @skrah
Files
  • _hashopenssl.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
    closed_at = <Date 2014-04-28.23:47:43.393>
    created_at = <Date 2013-10-28.11:53:18.691>
    labels = ['extension-modules', 'performance']
    title = 'Leak in _hashopenssl.c'
    updated_at = <Date 2014-04-28.23:47:43.390>
    user = 'https://github.com/skrah'

    bugs.python.org fields:

    activity = <Date 2014-04-28.23:47:43.390>
    actor = 'pitrou'
    assignee = 'christian.heimes'
    closed = True
    closed_date = <Date 2014-04-28.23:47:43.393>
    closer = 'pitrou'
    components = ['Extension Modules']
    creation = <Date 2013-10-28.11:53:18.691>
    creator = 'skrah'
    dependencies = []
    files = ['32394']
    hgrepos = []
    issue_num = 19420
    keywords = ['patch']
    message_count = 7.0
    messages = ['201527', '201528', '201530', '201622', '201623', '203156', '217451']
    nosy_count = 4.0
    nosy_names = ['pitrou', 'christian.heimes', 'skrah', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'resource usage'
    url = 'https://bugs.python.org/issue19420'
    versions = ['Python 3.4']

    @skrah
    Copy link
    Mannequin Author

    skrah mannequin commented Oct 28, 2013

    There's a leak in _hashopenssl.c. Patch attached.

    @tiran
    Copy link
    Member

    tiran commented Oct 28, 2013

    Which Python versions are affected?

    @tiran tiran added the extension-modules C modules in the Modules dir label Oct 28, 2013
    @tiran tiran self-assigned this Oct 28, 2013
    @tiran tiran added the performance Performance or resource usage label Oct 28, 2013
    @tiran
    Copy link
    Member

    tiran commented Oct 28, 2013

    2.7 isn't affected. It's not a security issue which means I'm not going to apply it to 3.2.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 29, 2013

    New changeset 6fdbb81b4020 by Christian Heimes in branch 'default':
    Issue bpo-19420: Fix reference leak in module initalization code of _hashopenssl.c
    http://hg.python.org/cpython/rev/6fdbb81b4020

    @tiran
    Copy link
    Member

    tiran commented Oct 29, 2013

    Fixed in 3.4

    Georg, 3.3 is currently in RC phase and this fix is not critical. Do you want me to commit it anyway or shall I wait until 3.3.3 has been released by you?

    @tiran
    Copy link
    Member

    tiran commented Nov 17, 2013

    ping

    @pitrou
    Copy link
    Member

    pitrou commented Apr 28, 2014

    3.3 is in security mode now, so this can be closed IMO.

    @pitrou pitrou closed this as completed Apr 28, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants