Win32 compiler warning in _sha3

[zware]

BPO	19520
Nosy	@tiran, @zware
Files	sha3_compile_warning.diff: Fix compiler warning

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zware'
closed_at = <Date 2013-11-18.04:10:42.548>
created_at = <Date 2013-11-07.15:41:52.160>
labels = ['type-feature', 'OS-windows', 'build']
title = 'Win32 compiler warning in _sha3'
updated_at = <Date 2013-11-18.04:10:42.547>
user = 'https://github.com/zware'

bugs.python.org fields:

activity = <Date 2013-11-18.04:10:42.547>
actor = 'zach.ware'
assignee = 'zach.ware'
closed = True
closed_date = <Date 2013-11-18.04:10:42.548>
closer = 'zach.ware'
components = ['Build', 'Windows']
creation = <Date 2013-11-07.15:41:52.160>
creator = 'zach.ware'
dependencies = []
files = ['32530']
hgrepos = []
issue_num = 19520
keywords = ['patch']
message_count = 5.0
messages = ['202344', '202348', '203148', '203243', '203244']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'python-dev', 'zach.ware']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19520'
versions = ['Python 3.4']

[zware]

There is only one remaining compiler warning on 32-bit Windows, see [1] (buildbot doubles warning counts on the Windows bots).

The warning is coming from Modules/_sha3/keccak/KeccakF-1600-opt32.c#l497, which uses extractLanes as defined on line 213.

The attached patch fixes the compiler warning, doesn't add any new ones, compiles, and doesn't break anything obvious. I don't know enough about it to be confident in whether this is the right fix, so I'll leave it up to you, Christian :)

Thanks,

Zach

[1] http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%203.x/builds/1682/steps/compile/logs/warnings%20%282%29

[tiran]

Thanks! I'll look into it.

I'd rather not change the reference implementation but in this case practicality beats purity. :)

[tiran]

Go ahead! Although I'd rather follow upstream as close as possible, this one is harmless.

[python-dev]

New changeset 259c82332199 by Zachary Ware in branch 'default':
Issue bpo-19520: Fix (the last!) compiler warning on 32bit Windows, in _sha3
http://hg.python.org/cpython/rev/259c82332199

[zware]

Thanks Christian, now committed.