New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 453: "make install" and "make altinstall" integration #63752
Comments
If nobody else gets to it first, I'll do this in the next couple of days. |
Here's a patch for review. It implements:
While testing the above I've identified a number of issues. I haven't had time to do more than a quick triage on most of them so the initial analyses may be wrong. Wheel installation issues:
General pip issues:
ensurepip issue:
Requirement already up-to-date: setuptools in /py/dev/3x/root/uxd/lib/python3.4/site-packages Perhaps ensurepip module should also set "--ignore-installed" when calling pip? Makefile: |
Thanks for the patch and the detailed feedback, Ned! I've pinged the pip folks on pypa/pip#1322 to help triage these issues as existing pip upstream issues. |
For 8 in particular, I'm inclined to push that over to the pip side of the fence (as with the first 7 points). pip knows that ensurepip is involved (due to ENSUREPIP_OPTIONS being set in the environment), so it may be able to check if the unversioned scripts are missing and generate them appropriately in that case. How do we want to proceed for the first beta? Given the integration timeline in the PEP (which doesn't require the shipped version of pip to be locked until just before beta 2), I'm inclined not to consider the additional quirks Ned found as blockers for beta 1, but we do need to get them fixed for beta 2. |
I think the most serious problem is 3 since it directly affects the end user. It would be good to have that fixed someway for 3.4.0b1. Resolutions to the other items could wait. |
Things that I see as issues so far I've created upstream tickets for, things that I still have questions on I didn't. |
For the record: the current "--default-pip" option is the one that was previously "--default-install". I switched it because having the default installation behaviour be something other than the behaviour requested via the "--default-install" option really didn't sound right to me. |
Thanks! |
New changeset 90d4153728f6 by Ned Deily in branch 'default': |
The proposed patch with minor changes is now pushed. I believe all of the review points have either been resolved or are covered by separate pip issues with the exception of item 8. For item 6 (permissions not being forced), I decided that there are so many other files that are also not having permissions forced that it is silly to single out ensurepip. bpo-15890 should cover a comprehensive solution for all files. In the meantime, the solution remains to set umask appropriately (e.g. 022) before running "make install" or "make altinstall". I'm removing "release blocker" status and propose closing this issue once a decision about and/or home for item 8 is found. |
I'm honestly not sure what to do about #8 on your list. It's sort of a really wierd edge case as far as pip is concerned right now because the support for the versioned commands and differing them is sort of a hack job while we wait for proper support from a PEP. Probably long term wise once there's support for this in a PEP pip will gain some sort of regenerate scripts commands that could handle this case better. I'm struggling to come up with a good solution in the interim though :( |
I moved the "make altinstall && make install" problem out to its own issue (bpo-19693) |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: