Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific asserts in http.cookiejar tests #63805

Closed
serhiy-storchaka opened this issue Nov 15, 2013 · 3 comments
Closed

Use specific asserts in http.cookiejar tests #63805

serhiy-storchaka opened this issue Nov 15, 2013 · 3 comments
Assignees
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 19606
Nosy @ezio-melotti, @serhiy-storchaka
Files
  • test_http_cookiejar_asserts.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2013-11-17.12:47:09.430>
    created_at = <Date 2013-11-15.09:55:20.578>
    labels = ['type-feature', 'tests']
    title = 'Use specific asserts in http.cookiejar tests'
    updated_at = <Date 2013-11-17.12:47:09.429>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2013-11-17.12:47:09.429>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2013-11-17.12:47:09.430>
    closer = 'serhiy.storchaka'
    components = ['Tests']
    creation = <Date 2013-11-15.09:55:20.578>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['32637']
    hgrepos = []
    issue_num = 19606
    keywords = ['patch']
    message_count = 3.0
    messages = ['202931', '203102', '203141']
    nosy_count = 3.0
    nosy_names = ['ezio.melotti', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue19606'
    versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']

    @serhiy-storchaka
    Copy link
    Member Author

    The proposed patch makes the http.cookiejar module tests use more specific asserts. This will provide more useful failure report.

    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Nov 15, 2013
    @ezio-melotti
    Copy link
    Member

    LGTM (I left a comment on rietveld).

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 17, 2013

    New changeset 9444ee6864b3 by Serhiy Storchaka in branch '3.3':
    Issue bpo-19606: Use specific asserts in http.cookiejar tests.
    http://hg.python.org/cpython/rev/9444ee6864b3

    New changeset c1f2b3fc965d by Serhiy Storchaka in branch 'default':
    Issue bpo-19606: Use specific asserts in http.cookiejar tests.
    http://hg.python.org/cpython/rev/c1f2b3fc965d

    New changeset 1479ba6bc511 by Serhiy Storchaka in branch '2.7':
    Issue bpo-19606: Use specific asserts in cookielib tests.
    http://hg.python.org/cpython/rev/1479ba6bc511

    @serhiy-storchaka serhiy-storchaka self-assigned this Nov 17, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants