Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pkgutil for anything missing for PEP 451 #63907

Closed
brettcannon opened this issue Nov 22, 2013 · 3 comments
Closed

Check pkgutil for anything missing for PEP 451 #63907

brettcannon opened this issue Nov 22, 2013 · 3 comments
Labels
stdlib Python modules in the Lib dir

Comments

@brettcannon
Copy link
Member

BPO 19708
Nosy @brettcannon, @ncoghlan, @ericsnowcurrently
Files
  • issue19708-use-new-api.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2014-01-04.22:16:20.960>
    created_at = <Date 2013-11-22.16:42:47.435>
    labels = ['library']
    title = 'Check pkgutil for anything missing for PEP 451'
    updated_at = <Date 2014-01-04.22:16:20.958>
    user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2014-01-04.22:16:20.958>
    actor = 'eric.snow'
    assignee = 'none'
    closed = True
    closed_date = <Date 2014-01-04.22:16:20.960>
    closer = 'eric.snow'
    components = ['Library (Lib)']
    creation = <Date 2013-11-22.16:42:47.435>
    creator = 'brett.cannon'
    dependencies = []
    files = ['33301']
    hgrepos = []
    issue_num = 19708
    keywords = ['patch']
    message_count = 3.0
    messages = ['207215', '207315', '207317']
    nosy_count = 5.0
    nosy_names = ['brett.cannon', 'ncoghlan', 'Arfrever', 'python-dev', 'eric.snow']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue19708'
    versions = ['Python 3.4']

    @brettcannon brettcannon added the stdlib Python modules in the Lib dir label Nov 22, 2013
    @ericsnowcurrently
    Copy link
    Member

    Here's a patch that does the minimum of updating pkgutil and its tests to move away from find_module/load_module. I'm not sure there is much more to do than this.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 4, 2014

    New changeset acebe574ab08 by Eric Snow in branch 'default':
    Issue bpo-19708: Update pkgutil to use the new importer APIs.
    http://hg.python.org/cpython/rev/acebe574ab08

    @ericsnowcurrently
    Copy link
    Member

    There wasn't much left to do for pkgutil after all. :)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants