TEST_DATA_DIR for out-of-tree builds

[tiran]

BPO	19745
Nosy	@tiran, @iritkatriel

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2013-11-24.02:40:50.173>
labels = ['type-bug', 'tests']
title = 'TEST_DATA_DIR for out-of-tree builds'
updated_at = <Date 2021-12-07.16:25:34.093>
user = 'https://github.com/tiran'

bugs.python.org fields:

activity = <Date 2021-12-07.16:25:34.093>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2013-11-24.02:40:50.173>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 19745
keywords = []
message_count = 3.0
messages = ['204166', '228404', '407948']
nosy_count = 2.0
nosy_names = ['christian.heimes', 'iritkatriel']
pr_nums = []
priority = 'low'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19745'
versions = ['Python 3.4', 'Python 3.5']

[tiran]

test.support declares a TEST_DATA_DIR directory inside the source tree of Python:

TEST_SUPPORT_DIR = os.path.dirname(os.path.abspath(__file__))
TEST_HOME_DIR = os.path.dirname(TEST_SUPPORT_DIR)
TEST_DATA_DIR = os.path.join(TEST_HOME_DIR, "data")

make distclean cleans up the very same directory, see r87481. This feature doesn't cope will with out-of-tree builds with a read-only source directory. It looks like this feature isn't used by any test module. Can I remove it?

[BreamoreBoy]

Can someone answer Christian's question please.

[iritkatriel]

It does seem to be used here:

cpython/Lib/test/support/__init__.py

Line 553 in a6c3b0f

fn = os.path.join(TEST_DATA_DIR, filename)