Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tests for dequereviter_new #64097

Closed
tiran opened this issue Dec 5, 2013 · 4 comments
Closed

No tests for dequereviter_new #64097

tiran opened this issue Dec 5, 2013 · 4 comments
Assignees
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@tiran
Copy link
Member

tiran commented Dec 5, 2013

BPO 19898
Nosy @rhettinger, @tiran, @PCManticore
Files
  • test_deque_19898.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/rhettinger'
    closed_at = <Date 2014-06-15.03:42:17.111>
    created_at = <Date 2013-12-05.15:16:53.106>
    labels = ['tests', 'type-bug', 'library']
    title = 'No tests for dequereviter_new'
    updated_at = <Date 2014-06-15.03:42:17.110>
    user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2014-06-15.03:42:17.110>
    actor = 'rhettinger'
    assignee = 'rhettinger'
    closed = True
    closed_date = <Date 2014-06-15.03:42:17.111>
    closer = 'rhettinger'
    components = ['Library (Lib)', 'Tests']
    creation = <Date 2013-12-05.15:16:53.106>
    creator = 'christian.heimes'
    dependencies = []
    files = ['33732']
    hgrepos = []
    issue_num = 19898
    keywords = ['patch']
    message_count = 4.0
    messages = ['205305', '209339', '220608', '220609']
    nosy_count = 4.0
    nosy_names = ['rhettinger', 'christian.heimes', 'Claudiu.Popa', 'python-dev']
    pr_nums = []
    priority = 'low'
    resolution = 'fixed'
    stage = 'patch review'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue19898'
    versions = ['Python 3.5']

    @tiran
    Copy link
    Member Author

    tiran commented Dec 5, 2013

    According to LCOV the dequereviter_new is never called by any test.

    http://tiran.bitbucket.org/python-lcov/Modules/_collectionsmodule.c.gcov.html#1408

    @tiran tiran added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Dec 5, 2013
    @PCManticore
    Copy link
    Mannequin

    PCManticore mannequin commented Jan 26, 2014

    Hi. Here's a patch.

    @rhettinger rhettinger self-assigned this Jun 14, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 15, 2014

    New changeset 4a48450f2505 by Raymond Hettinger in branch 'default':
    bpo-19898: Add test for dequereviter_new.
    http://hg.python.org/cpython/rev/4a48450f2505

    @rhettinger
    Copy link
    Contributor

    Thanks guys.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants