Wrong OSError message from os.rename() when dst is a non-empty directory

[jderose]

BPO	20093
Nosy	@doko42, @vstinner, @jwilk, @mitya57
Files	test_os_rename.py: Test case

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-07-26.16:18:39.687>
created_at = <Date 2013-12-29.00:50:27.534>
labels = ['type-bug', 'library']
title = 'Wrong OSError message from os.rename() when dst is a non-empty directory'
updated_at = <Date 2014-07-26.16:18:39.654>
user = 'https://bugs.python.org/jderose'

bugs.python.org fields:

activity = <Date 2014-07-26.16:18:39.654>
actor = 'doko'
assignee = 'none'
closed = True
closed_date = <Date 2014-07-26.16:18:39.687>
closer = 'doko'
components = ['Library (Lib)']
creation = <Date 2013-12-29.00:50:27.534>
creator = 'jderose'
dependencies = []
files = ['33285']
hgrepos = []
issue_num = 20093
keywords = []
message_count = 3.0
messages = ['207058', '207077', '224072']
nosy_count = 5.0
nosy_names = ['doko', 'vstinner', 'jwilk', 'jderose', 'mitya57']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20093'
versions = ['Python 3.4']

[jderose]

Under Python 3.3, if renaming a directory with os.rename() when the destination is an existing, non-empty directory, like this:

os.rename('/tmp/foo', '/tmp/bar')

You'll get an OSError with a message like this:

OSError: [Errno 39] Directory not empty: '/tmp/bar'

However, in the current Python 3.4.0b1 package in Ubuntu Trusty, this error message will contain the source directory name instead of the destination directory name, like this:

OSError: [Errno 39] Directory not empty: '/tmp/foo'

I've attached a test case, which also covers renaming directories relative to an open directory descriptor. This test case works on Python 3.3, fails on Python 3.4 Beta1.

[mitya57]

This is a result of http://hg.python.org/cpython/rev/6903f5214e99.

Looks like we should check the error code and conditionally set the file name to either src or dst.

[doko42]

3.4.0 has this fixed. resolutions in http://bugs.python.org/issue16074 and http://bugs.python.org/issue20517