Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation for the atTime parameter of TimedRotatimeFileHandler is confusing #64323

Closed
bitdancer opened this issue Jan 4, 2014 · 2 comments
Labels
docs Documentation in the Doc dir

Comments

@bitdancer
Copy link
Member

BPO 20124
Nosy @vsajip, @bitdancer

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-08-24.16:50:47.083>
created_at = <Date 2014-01-04.23:48:55.960>
labels = ['docs']
title = 'The documentation for the atTime parameter of TimedRotatimeFileHandler is confusing'
updated_at = <Date 2016-08-24.16:50:47.082>
user = 'https://github.com/bitdancer'

bugs.python.org fields:

activity = <Date 2016-08-24.16:50:47.082>
actor = 'python-dev'
assignee = 'docs@python'
closed = True
closed_date = <Date 2016-08-24.16:50:47.083>
closer = 'python-dev'
components = ['Documentation']
creation = <Date 2014-01-04.23:48:55.960>
creator = 'r.david.murray'
dependencies = []
files = []
hgrepos = []
issue_num = 20124
keywords = []
message_count = 2.0
messages = ['207323', '273578']
nosy_count = 4.0
nosy_names = ['vinay.sajip', 'r.david.murray', 'docs@python', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue20124'
versions = ['Python 3.4']

@bitdancer
Copy link
Member Author

The docs say that you can specify 'atTime' with a 'when' of 'midnight', but that makes no sense on the face of it. atTime with a weekday specification makes sense, but it would also make sense to use atTime with a when of D (and an interval), which is not mentioned as a possibility. It could also make sense to use it with other intervals (in other words, use the atTime as the starting point for the rotation calculation, instead of the last mod time or 'now'). If that doesn't work it should be stated that atTime will be ignored in those cases.

Probably all the time related entries should be rewritten with the existence of atTime in mind, in order to clarify all the possible (and not possible) interactions.

@bitdancer bitdancer added the docs Documentation in the Doc dir label Jan 4, 2014
@python-dev
Copy link
Mannequin

python-dev mannequin commented Aug 24, 2016

New changeset 8d13c1f33d21 by Vinay Sajip in branch 'default':
Closes bpo-20124: clarified usage of the atTime parameter in TimedRotatingFileHandler documentation.
https://hg.python.org/cpython/rev/8d13c1f33d21

@python-dev python-dev mannequin closed this as completed Aug 24, 2016
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

No branches or pull requests

1 participant