Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentClinic howto: document change in Py_buffer lifecycle management #64401

Closed
rmsr mannequin opened this issue Jan 9, 2014 · 5 comments
Closed

ArgumentClinic howto: document change in Py_buffer lifecycle management #64401

rmsr mannequin opened this issue Jan 9, 2014 · 5 comments
Labels
docs Documentation in the Doc dir

Comments

@rmsr
Copy link
Mannequin

rmsr mannequin commented Jan 9, 2014

BPO 20202
Nosy @larryhastings
Files
  • argument_clinic_PyBuffer_release.patch: verbiage tweaking
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2014-01-14.00:12:39.957>
    created_at = <Date 2014-01-09.06:47:42.424>
    labels = ['docs']
    title = 'ArgumentClinic howto: document change in Py_buffer lifecycle management'
    updated_at = <Date 2014-01-14.00:12:39.955>
    user = 'https://bugs.python.org/rmsr'

    bugs.python.org fields:

    activity = <Date 2014-01-14.00:12:39.955>
    actor = 'rmsr'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2014-01-14.00:12:39.957>
    closer = 'rmsr'
    components = ['Documentation']
    creation = <Date 2014-01-09.06:47:42.424>
    creator = 'rmsr'
    dependencies = []
    files = ['33435']
    hgrepos = []
    issue_num = 20202
    keywords = ['patch']
    message_count = 5.0
    messages = ['207728', '207814', '207982', '207983', '208061']
    nosy_count = 3.0
    nosy_names = ['larry', 'rmsr', 'docs@python']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue20202'
    versions = ['Python 3.4']

    @rmsr
    Copy link
    Mannequin Author

    rmsr mannequin commented Jan 9, 2014

    Almost didn't catch that PyBuffer_Release isn't needed. Also we need a verb/adjective for applying AC. Cure?

    "zlibmodule has already been cured."

    @rmsr rmsr mannequin assigned docspython Jan 9, 2014
    @rmsr rmsr mannequin added the docs Documentation in the Doc dir label Jan 9, 2014
    @larryhastings
    Copy link
    Contributor

    I've got a bunch of doc improvements in the rollup patch in bpo-20214. I invite you to give it a review. If that looks suitable please close this issue.

    As for a verb, I've been using "convert". "zlibmodule has already been converted to work with Argument Clinic".

    @rmsr
    Copy link
    Mannequin Author

    rmsr mannequin commented Jan 12, 2014

    Thank you for including the doc change in your other patch. As the grammar was off, instead of just fixing it I naturally rewrote it. Use this patch or just remove the extraneous "for you" as you prefer.

    @larryhastings
    Copy link
    Contributor

    Fixed in revision 43e109ca9018. Well, changed anyway, maybe it's still not wonderful text.

    @rmsr
    Copy link
    Mannequin Author

    rmsr mannequin commented Jan 14, 2014

    Even more imperative than my version. Excellent!

    @rmsr rmsr mannequin closed this as completed Jan 14, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant