Extract generated clinic code in Modules/_pickle.c to separate file

[serhiy-storchaka]

BPO	20395
Nosy	@pitrou, @larryhastings, @avassalotti, @serhiy-storchaka
Files	pickle_clinic.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-01-27.09:52:31.093>
created_at = <Date 2014-01-26.11:05:39.736>
labels = []
title = 'Extract generated clinic code in Modules/_pickle.c to separate file'
updated_at = <Date 2014-01-27.09:52:31.093>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2014-01-27.09:52:31.093>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-01-27.09:52:31.093>
closer = 'serhiy.storchaka'
components = []
creation = <Date 2014-01-26.11:05:39.736>
creator = 'serhiy.storchaka'
dependencies = []
files = ['33722']
hgrepos = []
issue_num = 20395
keywords = ['patch']
message_count = 5.0
messages = ['209293', '209295', '209348', '209369', '209423']
nosy_count = 5.0
nosy_names = ['pitrou', 'larry', 'alexandre.vassalotti', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue20395'
versions = ['Python 3.4']

[serhiy-storchaka]

Argument Clinic had added about half-thousand lines of code to Modules/_pickle.c. This generated code is mixed with handwritten code. Last 8 changes of Modules/_pickle.c are caused by Argument Clinic evolution, and I afraid that many future Argument Clinic changes will change Modules/_pickle.c too.

The proposed patch extracts generated clinic code in separate file to prevent or decrease code churn in future. It decreases the size of Modules/_pickle.c by 450 lines.

[larryhastings]

Alexandre: We're still figuring out best practices with Argument Clinic. So, right now, there's no standard policy of "where should we put all the generated code?", and we're leaving it up to the owners of the individual modules. Putting it in a second file and #including it is a popular option, but there are other options too (and Guido says he hates code generators that put stuff in a second file).

[pitrou]

+1 for a separate file from me.

[avassalotti]

+1 from me as well for a separate file.

[python-dev]

New changeset 1aa8ea187560 by Serhiy Storchaka in branch 'default':
Issue bpo-20395: Extract generated clinic code in Modules/_pickle.c to separate file.
http://hg.python.org/cpython/rev/1aa8ea187560