Code generated by asdl_c.py not C89-compliant

[JeffreyArmstrong]

BPO	20588
Nosy	@benjaminp
Files	asdl_c.py.trunk.patch: Minor change to asdl_c.py for C89 compliance

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-02-11.03:41:49.144>
created_at = <Date 2014-02-11.01:33:11.866>
labels = ['interpreter-core', 'build']
title = 'Code generated by asdl_c.py not C89-compliant'
updated_at = <Date 2014-02-11.03:41:49.125>
user = 'https://bugs.python.org/JeffreyArmstrong'

bugs.python.org fields:

activity = <Date 2014-02-11.03:41:49.125>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-02-11.03:41:49.144>
closer = 'python-dev'
components = ['Interpreter Core']
creation = <Date 2014-02-11.01:33:11.866>
creator = 'Jeffrey.Armstrong'
dependencies = []
files = ['34032']
hgrepos = []
issue_num = 20588
keywords = ['patch']
message_count = 2.0
messages = ['210894', '210898']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'python-dev', 'Jeffrey.Armstrong']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue20588'
versions = ['Python 3.3', 'Python 3.4']

[JeffreyArmstrong]

The code within Python/Python-ast.c does not currently conform to C89 standard. Within the function PyAST_obj2mod(), the array 'req_type' is initialized using runtime values, which is not allowed by the standard, causing building to fail on a C89 compiler.

This code is automatically generated by asdl_c.py. I've attached a patch which corrects the problem. Python/Python-ast.c will need to be regenerated if this patch is accepted.

[python-dev]

New changeset 5b3bb4bda9cb by Benjamin Peterson in branch '3.3':
don't put runtime values in array initializer for C89 compliance (closes bpo-20588)
http://hg.python.org/cpython/rev/5b3bb4bda9cb

New changeset cdaf7b38bb2c by Benjamin Peterson in branch 'default':
merge 3.3 (bpo-20588)
http://hg.python.org/cpython/rev/cdaf7b38bb2c