test_subprocess is not executed in python -m test.test_asyncio

[vajrasky]

BPO	20655
Nosy	@gvanrossum, @vstinner, @vajrasky
Files	add_subprocess_to_tests.patch permanent_fix_for_executing_test_asyncio_in_bundle.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-02-17.23:13:11.417>
created_at = <Date 2014-02-17.08:28:15.543>
labels = ['type-bug', 'tests']
title = 'test_subprocess is not executed in python -m test.test_asyncio'
updated_at = <Date 2014-03-17.06:30:47.085>
user = 'https://github.com/vajrasky'

bugs.python.org fields:

activity = <Date 2014-03-17.06:30:47.085>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-02-17.23:13:11.417>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2014-02-17.08:28:15.543>
creator = 'vajrasky'
dependencies = []
files = ['34114', '34115']
hgrepos = []
issue_num = 20655
keywords = ['patch']
message_count = 7.0
messages = ['211398', '211399', '211402', '211429', '211454', '211456', '213802']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'vstinner', 'python-dev', 'vajrasky']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20655'
versions = ['Python 3.4']

[vajrasky]

ethan@amiau:/Documents/code/python/cpython3.4$ cat Lib/test/test_asyncio/tests.txt
test_asyncio.test_base_events
test_asyncio.test_events
test_asyncio.test_futures
test_asyncio.test_locks
test_asyncio.test_proactor_events
test_asyncio.test_queues
test_asyncio.test_selector_events
test_asyncio.test_streams
test_asyncio.test_tasks
test_asyncio.test_transports
test_asyncio.test_unix_events
test_asyncio.test_windows_events
test_asyncio.test_windows_utils
ethan@amiau:/Documents/code/python/cpython3.4$ ls Lib/test/test_asyncio/test_subprocess.py
Lib/test/test_asyncio/test_subprocess.py

I provide two alternatives to fix this problem.

The first is to add subprocess in tests.txt.

[vajrasky]

The second is the permanent fix so we don't need to add new test to tests.txt every time we want to add new test to asyncio test bundle.

[vstinner]

I prefer to dynamically discover tests, as we do in all other Python tests. I don't like hardcoded list, it leads to such issue.

@guido: What do you think?

[gvanrossum]

Please apply the fix and make sure it gets cherry-picked.

I agree on dynamic test recovery but don't find it a high priority.

[python-dev]

New changeset b3987d758e49 by Victor Stinner in branch 'default':
Issue bpo-20655: Fix test_asyncio, run also subprocess tests. Patch written by
http://hg.python.org/cpython/rev/b3987d758e49

[vstinner]

Thanks Vajrasky for your fix. You may open a new issue for permanent_fix_for_executing_test_asyncio_in_bundle.patch.

[python-dev]

New changeset b22b83ea719d by Victor Stinner in branch '3.4':
Issue bpo-20655: Fix test_asyncio, run also subprocess tests. Patch written by
http://hg.python.org/cpython/rev/b22b83ea719d