3.4 cherry-pick: bf413a97f1a9 fix conflicting hypot definition with VS 2010

[zware]

BPO	20707
Nosy	@larryhastings, @zware

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/larryhastings'
closed_at = <Date 2014-02-20.23:30:59.113>
created_at = <Date 2014-02-20.21:56:14.146>
labels = ['type-bug', 'OS-windows', 'build', 'release-blocker']
title = '3.4 cherry-pick: bf413a97f1a9 fix conflicting hypot definition with VS 2010'
updated_at = <Date 2014-02-20.23:30:59.112>
user = 'https://github.com/zware'

bugs.python.org fields:

activity = <Date 2014-02-20.23:30:59.112>
actor = 'larry'
assignee = 'larry'
closed = True
closed_date = <Date 2014-02-20.23:30:59.113>
closer = 'larry'
components = ['Build', 'Windows']
creation = <Date 2014-02-20.21:56:14.146>
creator = 'zach.ware'
dependencies = []
files = []
hgrepos = []
issue_num = 20707
keywords = []
message_count = 2.0
messages = ['211756', '211763']
nosy_count = 2.0
nosy_names = ['larry', 'zach.ware']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20707'
versions = ['Python 3.4']

[zware]

PC/pyconfig.h does "#define hypot _hypot", but VS 2010 and above already define a hypot function (implemented by _hypot), which results in a warning if you have warning 4211 enabled (which warning level 4 does) or a recursive definition which results in a crash at runtime, depending on how you use Python.h. Python itself doesn't suffer from the runtime crash, but Blender does because of Python.

bf413a97f1a9 fixes it by guarding the #define with #if _MSC_VER < 1600.

This one is kind of borderline for RC phase in my mind, so I leave it up to you to decide, Larry. It is a serious issue for at least Blender and one other extension author. On the other hand, this issue has been around since 3.3.0 (the first VS 2010-supporting release) and was only reported this January.

[larryhastings]

ok. it's a low-risk fix.