Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Mac folder icon #65305

Closed
viveksjain mannequin opened this issue Mar 30, 2014 · 16 comments
Closed

Updated Mac folder icon #65305

viveksjain mannequin opened this issue Mar 30, 2014 · 16 comments
Assignees
Labels
OS-mac type-feature A feature request or enhancement

Comments

@viveksjain
Copy link
Mannequin

viveksjain mannequin commented Mar 30, 2014

BPO 21106
Nosy @loewis, @ronaldoussoren, @ned-deily, @ezio-melotti, @bitdancer, @willingc
PRs
  • [trivial] Update Python Folder.icns icon file to match new macOS look #1780
  • Files
  • Python Folder.icns: Proposed new Mac icon
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ned-deily'
    closed_at = <Date 2019-06-06.19:44:26.316>
    created_at = <Date 2014-03-30.21:14:17.812>
    labels = ['OS-mac', 'type-feature']
    title = 'Updated Mac folder icon'
    updated_at = <Date 2019-06-06.19:44:26.315>
    user = 'https://bugs.python.org/viveksjain'

    bugs.python.org fields:

    activity = <Date 2019-06-06.19:44:26.315>
    actor = 'willingc'
    assignee = 'ned.deily'
    closed = True
    closed_date = <Date 2019-06-06.19:44:26.316>
    closer = 'willingc'
    components = ['macOS']
    creation = <Date 2014-03-30.21:14:17.812>
    creator = 'viveksjain'
    dependencies = []
    files = ['34671']
    hgrepos = []
    issue_num = 21106
    keywords = ['patch']
    message_count = 16.0
    messages = ['215200', '215201', '215202', '215204', '215205', '215206', '215208', '215209', '215212', '216662', '216670', '269110', '269176', '269177', '269182', '344862']
    nosy_count = 8.0
    nosy_names = ['loewis', 'ronaldoussoren', 'ned.deily', 'ezio.melotti', 'r.david.murray', 'jrus', 'willingc', 'viveksjain']
    pr_nums = ['1780']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'patch review'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue21106'
    versions = ['Python 3.5']

    @viveksjain
    Copy link
    Mannequin Author

    viveksjain mannequin commented Mar 30, 2014

    Python 3 still uses an old-style Mac folder icon in its installer (https://github.com/python-git/python/blob/master/Mac/Icons/Python%20Folder.icns?raw=true) that looks out of place on recent Macs. I created a quick replacement that is higher res and fits in better.

    @viveksjain viveksjain mannequin added OS-mac type-feature A feature request or enhancement labels Mar 30, 2014
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Mar 30, 2014

    Can you please submit a contributor form, and indicate that you are willing to license the icon under this agreement?

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Mar 30, 2014

    We should probably also ask for the PSF's permission (from the trademark committee) to use this specific modification of the logo in CPython.

    @viveksjain
    Copy link
    Mannequin Author

    viveksjain mannequin commented Mar 30, 2014

    Submitted the patch, and I license the icon under the PSF contributor agreement. To make the icon, I used: (1) the default Apple folder icon as a starting point and (2) the Python icon from https://www.python.org/community/logos/ (but with modified colors). For (1), not sure if there are any copyright issues involved and if so how to get proper permission from Apple. I'm guessing the old icon also used the default Mac folder icon at the time. For (2), I defer to your expertise to find out the right people to contact to get it approved.

    @viveksjain
    Copy link
    Mannequin Author

    viveksjain mannequin commented Mar 30, 2014

    By "Submitted the patch" I meant "Submitted the contributor agreement."

    @ezio-melotti
    Copy link
    Member

    Regarding the Python logo, you should write to psf-trademarks@python.org, tell them that you used the logo for the icon and add a link to this issue.
    I'm sure they will be happy to let you use it, but it's good to let them know.

    @viveksjain
    Copy link
    Mannequin Author

    viveksjain mannequin commented Mar 30, 2014

    I just emailed psf-trademarks@python.org (and CC'd assignee ned.deily) requesting permission to use the logo.

    @ned-deily
    Copy link
    Member

    Thanks for your contribution. I think the more important issue here is the use of the Apple folder icon. Someone would need to research what restrictions if any exist before we could consider using an icon based on it.

    The current icons were added back in 2006. I don't know whether they were based on Apple icons and/or to what extent license issues were researched then. Perhaps Jacob or Ronald remembers. If there is a question, we could just eliminate use of the folder icon

    changeset: 38177:676492a93c8a
    branch: legacy-trunk
    user: Ronald Oussoren <ronaldoussoren@mac.com>
    date: Sun May 14 20:35:41 2006 +0000
    files: Mac/OSX/Icons/Disk Image.icns Mac/OSX/Icons/IDLE.icns Mac/OSX/Icons/Python Folder.icns Mac/OSX/Icons/PythonCompiled.icns Mac/OSX/Icons/PythonLauncher.icns Mac/OSX/Icons/PythonSource.icns Mac/
    description:
    A first cut at replacing the icons on MacOS X. This replaces all icons by icons
    based on the new python.org logo. These are also the first icons that are
    "proper" OSX icons.

    These icons were created by Jacob Rus.

    @viveksjain
    Copy link
    Mannequin Author

    viveksjain mannequin commented Mar 30, 2014

    Some searching turned up http://www.apple.com/legal/contact/#copyright. I have contacted Apple through the form and will keep you guys updated. Hopefully they will respond.

    @viveksjain
    Copy link
    Mannequin Author

    viveksjain mannequin commented Apr 17, 2014

    No reply from Apple yet, so I'm guessing at this stage they won't be responding. Does anyone have any contacts at Apple they could nudge to have a look at this? :) The other option is to recreate something that looks like Apple's folder icon but isn't. There is a tutorial at http://www.tutorial9.net/tutorials/photoshop-tutorials/photoshop-tutorial-design-the-mac-os-x-leopard-folder/ (I actually used the tutorial to create the current icon, but I only used step 10).

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Apr 17, 2014

    I see. I read the tutorial as actually giving permission to use these very shapes and forms for an icon. So if the resulting icon is (or could be) the result of following these steps, my layman's interpretation is that we have permission to use it.

    However, the PSF has legal council for exactly this question. Please ask psf@python.org (with reference to this issue) whether they want to have a say in this, and if so, what their legal advise is.

    @willingc
    Copy link
    Contributor

    Closing as an out of date issue (greater than 2 years old).

    @bitdancer
    Copy link
    Member

    We do not close issues just because they are old. Someone could still pick this up and contact psf legal and get this merged.

    @bitdancer bitdancer reopened this Jun 24, 2016
    @willingc
    Copy link
    Contributor

    R. David, I'm confused. There isn't anything actionable from a development standpoint on this issue. Why wouldn't it be marked languishing.

    @bitdancer
    Copy link
    Member

    Someone from the development team can contact legal, so yes there is a development action item here.

    It could be marked as languishing, but that status hasn't actually proven useful in practice and I think we should drop it.

    @willingc
    Copy link
    Contributor

    willingc commented Jun 6, 2019

    This was resolved in #1780. Thanks @ned.deily.

    @willingc willingc closed this as completed Jun 6, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    OS-mac type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    5 participants