Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect comments in nturl2path.py #65359

Closed
JurkoGospodneti mannequin opened this issue Apr 5, 2014 · 4 comments
Closed

incorrect comments in nturl2path.py #65359

JurkoGospodneti mannequin opened this issue Apr 5, 2014 · 4 comments
Assignees
Labels
OS-windows stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@JurkoGospodneti
Copy link
Mannequin

JurkoGospodneti mannequin commented Apr 5, 2014

BPO 21160
Nosy @serhiy-storchaka

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-10-24.14:45:52.114>
created_at = <Date 2014-04-05.10:45:36.747>
labels = ['type-feature', 'library', 'OS-windows']
title = 'incorrect comments in nturl2path.py'
updated_at = <Date 2015-10-24.14:45:52.113>
user = 'https://bugs.python.org/JurkoGospodneti'

bugs.python.org fields:

activity = <Date 2015-10-24.14:45:52.113>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-10-24.14:45:52.114>
closer = 'serhiy.storchaka'
components = ['Library (Lib)', 'Windows']
creation = <Date 2014-04-05.10:45:36.747>
creator = 'Jurko.Gospodneti\xc4\x87'
dependencies = []
files = []
hgrepos = ['230']
issue_num = 21160
keywords = ['patch']
message_count = 4.0
messages = ['215592', '253406', '253407', '253408']
nosy_count = 3.0
nosy_names = ['Jurko.Gospodneti\xc4\x87', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21160'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']

@JurkoGospodneti
Copy link
Mannequin Author

JurkoGospodneti mannequin commented Apr 5, 2014

nturl2path.py module contains comments implying that it converts local paths to URLs with ':' characters replaced with '|'. This has not been true since Python 2.6.

Commit at:

http://bitbucket.org/jurko/cpython/commits/8fe56380b09e238f104ba4a4d7a67df73182bc21

updates those comments - prepared against the CPython development repo.

@JurkoGospodneti JurkoGospodneti mannequin added stdlib Python modules in the Lib dir OS-windows labels Apr 5, 2014
@serhiy-storchaka
Copy link
Member

LGTM.

@serhiy-storchaka serhiy-storchaka self-assigned this Oct 24, 2015
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Oct 24, 2015
@python-dev
Copy link
Mannequin

python-dev mannequin commented Oct 24, 2015

New changeset 6a15845142ec by Serhiy Storchaka in branch '3.4':
bpo-21160: Correct comments in nturl2path. Patch by Jurko Gospodnetić.
https://hg.python.org/cpython/rev/6a15845142ec

New changeset acc453391c5b by Serhiy Storchaka in branch '2.7':
bpo-21160: Correct comments in nturl2path. Patch by Jurko Gospodnetić.
https://hg.python.org/cpython/rev/acc453391c5b

New changeset 67dfa5cf38c2 by Serhiy Storchaka in branch '3.5':
bpo-21160: Correct comments in nturl2path. Patch by Jurko Gospodnetić.
https://hg.python.org/cpython/rev/67dfa5cf38c2

New changeset 1216494acffe by Serhiy Storchaka in branch 'default':
bpo-21160: Correct comments in nturl2path. Patch by Jurko Gospodnetić.
https://hg.python.org/cpython/rev/1216494acffe

@serhiy-storchaka
Copy link
Member

Thank you for your patch Jurko.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-windows stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant