sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

[AlexLordThorsen]

BPO	21250
Nosy	@ned-deily, @berkerpeksag, @raulcd
Files	sqlite_tests.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-09-06.23:07:57.597>
created_at = <Date 2014-04-16.07:52:41.485>
labels = ['tests', 'type-feature', 'library']
title = "sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality."
updated_at = <Date 2016-09-06.23:07:57.595>
user = 'https://bugs.python.org/AlexLordThorsen'

bugs.python.org fields:

activity = <Date 2016-09-06.23:07:57.595>
actor = 'berker.peksag'
assignee = 'ghaering'
closed = True
closed_date = <Date 2016-09-06.23:07:57.597>
closer = 'berker.peksag'
components = ['Library (Lib)', 'Tests']
creation = <Date 2014-04-16.07:52:41.485>
creator = 'Alex.LordThorsen'
dependencies = []
files = ['39052']
hgrepos = []
issue_num = 21250
keywords = ['patch']
message_count = 7.0
messages = ['216448', '216538', '216580', '241160', '268364', '274658', '274659']
nosy_count = 6.0
nosy_names = ['ghaering', 'ned.deily', 'python-dev', 'berker.peksag', 'Alex.LordThorsen', 'raulcd']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21250'
versions = ['Python 3.5', 'Python 3.6']

[AlexLordThorsen]

In Lib/sqlite3/tests/dbapi.py there are no unit tests which test out sqlite3's 'insert or [algorithm].' These algorithms are also referred to as SQL 'insert on conflict.'

More details at,
https://www.sqlite.org/lang_conflict.html

Not having unit tests for these features, especially 'insert or rollback,' seems like an easy way for timing and threading bugs to get lost in the database api.

[ned-deily]

Are you interested in submitting a patch?

[AlexLordThorsen]

Yes, I'm going to work on one after I fix bpo-16864 today.

[AlexLordThorsen]

I've added a set of tests which test the insert or [algorithm] branch of sqlite. It took some getting used to python.sqlite3's transaction model but I think I have a much better understanding now.

[berkerpeksag]

Thanks for the patch Alex. Some quick review comments:

• We need to skip SqliteOnConflictTests if the installed sqlite3 doesn't support the feature

• There is no need to duplicate https://www.sqlite.org/lang_conflict.html in every test. You can add it to SqliteOnConflictTests docstring.

• Instead of try: <something> except sqlite.IntegrityError: <pass> we can make sure that sqlite.IntegrityError is raised by using assertRaises (like you did in CheckOnConflictFail.)

• The following pattern can be replaced with a list comprehension:

  + returned_rows = []
  + for row in self.cu:
  + returned_rows.append(row)

[python-dev]

New changeset 91d3022b3f03 by Berker Peksag in branch '3.5':
Issue bpo-21250: Add tests for SQLite's ON CONFLICT clause
https://hg.python.org/cpython/rev/91d3022b3f03

New changeset db2bedd5c34a by Berker Peksag in branch 'default':
Issue bpo-21250: Merge from 3.5
https://hg.python.org/cpython/rev/db2bedd5c34a

[berkerpeksag]

Thanks for the patch, Alex!