mark test_devpoll to be meaningful only for Solaris

[AapoRantalainen]

BPO	21316
Nosy	@jcea, @bitdancer

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/jcea'
closed_at = <Date 2014-04-29.16:20:09.620>
created_at = <Date 2014-04-20.18:36:52.745>
labels = ['tests']
title = 'mark test_devpoll to be meaningful only for Solaris'
updated_at = <Date 2014-05-05.20:44:33.873>
user = 'https://bugs.python.org/AapoRantalainen'

bugs.python.org fields:

activity = <Date 2014-05-05.20:44:33.873>
actor = 'r.david.murray'
assignee = 'jcea'
closed = True
closed_date = <Date 2014-04-29.16:20:09.620>
closer = 'jcea'
components = ['Tests']
creation = <Date 2014-04-20.18:36:52.745>
creator = 'AapoRantalainen'
dependencies = []
files = []
hgrepos = []
issue_num = 21316
keywords = []
message_count = 4.0
messages = ['216913', '217526', '217527', '217954']
nosy_count = 4.0
nosy_names = ['jcea', 'r.david.murray', 'python-dev', 'AapoRantalainen']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21316'
versions = ['Python 3.4', 'Python 3.5']

[AapoRantalainen]

[ 96/389/2] test_devpoll
Actual happened:
test_devpoll skipped -- select.devpoll not defined
Excepted:
test works only on Solaris

Took me a while until I read documentation:
select.devpoll()
-> (Only supported on Solaris and derivatives.)

Even test itself, test_devpoll.py, doesn't mention it is only for Solaris.

[python-dev]

New changeset cc2345e6e9ff by Jesus Cea in branch '3.4':
Closes issue bpo-21316: mark test_devpoll to be meaningfull only for Solaris
http://hg.python.org/cpython/rev/cc2345e6e9ff

New changeset 825c67196aac by Jesus Cea in branch 'default':
MERGE: Closes issue bpo-21316: mark test_devpoll to be meaningfull only for Solaris
http://hg.python.org/cpython/rev/825c67196aac

[jcea]

Thanks for the head-up!!. Can you compile new version and try it out?.

[bitdancer]

There's no pressing reason to revisit this, but...I think it would be better to say "works only on systems that support devpoll (ie: Solaris and derivatives)" Also, as long as you are changing the try/except, you could use skipUnless(hasattr(select, 'devpoll'), ...) instead of an if.