Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize -pthread #65660

Closed
0-wiz-0 mannequin opened this issue May 9, 2014 · 5 comments
Closed

Recognize -pthread #65660

0-wiz-0 mannequin opened this issue May 9, 2014 · 5 comments
Labels
3.11 only security fixes build The build process and cross-build type-feature A feature request or enhancement

Comments

@0-wiz-0
Copy link
Mannequin

0-wiz-0 mannequin commented May 9, 2014

BPO 21461
Nosy @tiran, @0-wiz-0
PRs
  • bpo-21461: teach makesetup about the -pthread flag #30032
  • Files
  • pthread.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-12-10.23:08:50.485>
    created_at = <Date 2014-05-09.09:16:03.612>
    labels = ['type-feature', 'build', '3.11']
    title = 'Recognize -pthread'
    updated_at = <Date 2021-12-10.23:08:50.484>
    user = 'https://github.com/0-wiz-0'

    bugs.python.org fields:

    activity = <Date 2021-12-10.23:08:50.484>
    actor = 'wiz'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-12-10.23:08:50.485>
    closer = 'wiz'
    components = ['Build']
    creation = <Date 2014-05-09.09:16:03.612>
    creator = 'wiz'
    dependencies = []
    files = ['35197']
    hgrepos = []
    issue_num = 21461
    keywords = ['patch']
    message_count = 5.0
    messages = ['218144', '408236', '408238', '408241', '408256']
    nosy_count = 2.0
    nosy_names = ['christian.heimes', 'wiz']
    pr_nums = ['30032']
    priority = 'normal'
    resolution = None
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue21461'
    versions = ['Python 3.11']

    @0-wiz-0
    Copy link
    Mannequin Author

    0-wiz-0 mannequin commented May 9, 2014

    makesetup should know about the "-pthread" compiler flag.

    @0-wiz-0 0-wiz-0 mannequin added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels May 9, 2014
    @tiran
    Copy link
    Member

    tiran commented Dec 10, 2021

    Which platforms or compilers use -pthread?

    @tiran tiran added build The build process and cross-build 3.11 only security fixes and removed extension-modules C modules in the Modules dir labels Dec 10, 2021
    @0-wiz-0
    Copy link
    Mannequin Author

    0-wiz-0 mannequin commented Dec 10, 2021

    gcc supports this flag. According to the man page:

    This option consistently for both compilation and linking. This option is supported on GNU/Linux targets, most other Unix derivatives, and also on x86 Cygwin and MinGW targets.

    On NetBSD, using -pthread is the recommended method to enable thread support.

    clang on NetBSD also supports this flag. I don't have access to clang on other systems.

    @tiran
    Copy link
    Member

    tiran commented Dec 10, 2021

    Python's configure script should detect when a platform needs -pthread and automatically include the flags for linking and compiling of all files. Under which circumstances do you need -pthread in a Setup file?

    @0-wiz-0
    Copy link
    Mannequin Author

    0-wiz-0 mannequin commented Dec 10, 2021

    I must confess, I don't know.
    This patch has been in pkgsrc since at least the import of the first python 2.7 package in 2011, and I haven't dug deeper.

    If you think it is unnecessary, I'll trust you. I've just removed it from the python 3.10 package in pkgsrc.

    @0-wiz-0 0-wiz-0 mannequin closed this as completed Dec 10, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant