Not so correct documentation about asyncio.subprocess_shell method

[vajrasky]

BPO	21758
Nosy	@gvanrossum, @vstinner, @1st1, @vajrasky
Files	fix_doc_asyncio_subprocess_shell.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-06-19.15:40:51.150>
created_at = <Date 2014-06-14.16:17:58.359>
labels = ['docs', 'expert-asyncio']
title = 'Not so correct documentation about asyncio.subprocess_shell method'
updated_at = <Date 2014-06-19.15:40:51.149>
user = 'https://github.com/vajrasky'

bugs.python.org fields:

activity = <Date 2014-06-19.15:40:51.149>
actor = 'vstinner'
assignee = 'docs@python'
closed = True
closed_date = <Date 2014-06-19.15:40:51.150>
closer = 'vstinner'
components = ['Documentation', 'asyncio']
creation = <Date 2014-06-14.16:17:58.359>
creator = 'vajrasky'
dependencies = []
files = ['35634']
hgrepos = []
issue_num = 21758
keywords = ['patch']
message_count = 4.0
messages = ['220567', '220620', '220962', '220963']
nosy_count = 6.0
nosy_names = ['gvanrossum', 'vstinner', 'docs@python', 'python-dev', 'yselivanov', 'vajrasky']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21758'
versions = ['Python 3.4', 'Python 3.5']

[vajrasky]

subprocess_shell in asyncio accepts cmd as a string or a bytes but the test unit, the documentation and the exception indicates that it only accepts a string.

[vstinner]

IMO it's fine to support bytes on UNIX, os.fsencode() is well defined. On
Windows, we may use the same decoder.

[python-dev]

New changeset 24c356168cc8 by Victor Stinner in branch '3.4':
Closes bpo-21758: asyncio doc: mention explicitly that subprocess parameters are
http://hg.python.org/cpython/rev/24c356168cc8

New changeset b57cdb945bf9 by Victor Stinner in branch 'default':
(Merge 3.4) Closes bpo-21758: asyncio doc: mention explicitly that subprocess
http://hg.python.org/cpython/rev/b57cdb945bf9

[vstinner]

A "string" can be a bytes string or a character string. I modified the documentation to be more explicitly, but IMO it's fine to keep "string" term in unit tests and error messages. You should not get the "string" error message if you pass a bytes or str object.