turtle.shapetransform doesn't transform the turtle on the first call

[LitaCho]

BPO	21812
Nosy	@rhettinger
Files	turtle_shapetransform.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/rhettinger'
closed_at = <Date 2014-06-22.08:29:08.139>
created_at = <Date 2014-06-20.06:14:39.986>
labels = ['type-bug', 'library']
title = "turtle.shapetransform doesn't transform the turtle on the first call"
updated_at = <Date 2014-06-22.22:47:00.350>
user = 'https://bugs.python.org/LitaCho'

bugs.python.org fields:

activity = <Date 2014-06-22.22:47:00.350>
actor = 'Lita.Cho'
assignee = 'rhettinger'
closed = True
closed_date = <Date 2014-06-22.08:29:08.139>
closer = 'rhettinger'
components = ['Library (Lib)']
creation = <Date 2014-06-20.06:14:39.986>
creator = 'Lita.Cho'
dependencies = []
files = ['35714']
hgrepos = []
issue_num = 21812
keywords = ['patch']
message_count = 5.0
messages = ['221068', '221130', '221231', '221233', '221322']
nosy_count = 4.0
nosy_names = ['rhettinger', 'jesstess', 'python-dev', 'Lita.Cho']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21812'
versions = ['Python 3.4', 'Python 3.5']

[LitaCho]

When you call turtle.shapetransform with a transformation matrix, nothing happens. You have to call turtle.shapesize or turtle.shearfactor first before turtle.shapetransform will take affect. Here is an example.

turtle.shapetransform(2,0,0,2) 
turtle.shapesize(1) 
turtle.shapetransform(2,0,0,2)

Nothing happens with the first call of shapetransform, but after calling shapesize, shapetransform then doubles in size, like it should.

[LitaCho]

Have a patch that fixes this. Rather than calling self._update() directory, we should be calling self._pen(resizemode="user"), since the user is changing the size of the turtle, just like how shapesize and shearfactor are updating.

[python-dev]

New changeset 39b094798e14 by Raymond Hettinger in branch '3.4':
Issue bpo-21812: Trigger immediate transformation in turtle.shapetransform().
http://hg.python.org/cpython/rev/39b094798e14

[rhettinger]

Thanks for noticing this and for the patch.

In the future, to make patches easier to review, please isolate the core logic change from inconsequential whitespace and linewrap edits. Also note that breaking strings in the middle to accommodate a max line length can be error-prone (in this case a space was dropped between "matrix:" and "must").

[LitaCho]

Absolutely! I totally forgot I made those changes for PEP-8! Next time, I will totally submit just the change associated with the ticket.

Thank you, Raymond, for the feedback and reviewing my code!