Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysmodule.c, #define terminated with semicolon. #66090

Closed
JohnMalmberg mannequin opened this issue Jul 1, 2014 · 3 comments
Closed

sysmodule.c, #define terminated with semicolon. #66090

JohnMalmberg mannequin opened this issue Jul 1, 2014 · 3 comments

Comments

@JohnMalmberg
Copy link
Mannequin

JohnMalmberg mannequin commented Jul 1, 2014

BPO 21891
Nosy @ned-deily

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-07-01.06:32:38.131>
created_at = <Date 2014-07-01.04:40:46.655>
labels = []
title = 'sysmodule.c, #define terminated with semicolon.'
updated_at = <Date 2014-07-01.06:32:38.129>
user = 'https://bugs.python.org/JohnMalmberg'

bugs.python.org fields:

activity = <Date 2014-07-01.06:32:38.129>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2014-07-01.06:32:38.131>
closer = 'ned.deily'
components = []
creation = <Date 2014-07-01.04:40:46.655>
creator = 'John.Malmberg'
dependencies = []
files = []
hgrepos = []
issue_num = 21891
keywords = []
message_count = 3.0
messages = ['222007', '222014', '222015']
nosy_count = 3.0
nosy_names = ['ned.deily', 'python-dev', 'John.Malmberg']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21891'
versions = ['Python 3.4', 'Python 3.5']

@JohnMalmberg
Copy link
Mannequin Author

JohnMalmberg mannequin commented Jul 1, 2014

Minor issue, the #define TAG line incorrectly is terminated with a semicolon.

This results in a double semicolon on the following line where the macro is expanded.

As this is an informational message, this is just cosmetic.

Listing fragment:

␉······· 25861 #define MAJOR STRIFY(PY_MAJOR_VERSION)
␉······· 25862 #define MINOR STRIFY(PY_MINOR_VERSION)
␉······· 25863 #define TAG NAME "-" MAJOR MINOR;
␉······· 25864 const char *_PySys_ImplCacheTag = TAG;
␉·······␉·······.....................................1
%CC-I-EXTRASEMI, (1) Extraneous semicolon.

   E␉·······                                "cpython" "-" "3" "5" ;

@python-dev
Copy link
Mannequin

python-dev mannequin commented Jul 1, 2014

New changeset 50e924d26ba6 by Ned Deily in branch '3.4':
Issue bpo-21891: remove extraneous semicolon.
http://hg.python.org/cpython/rev/50e924d26ba6

New changeset fc527ecb4487 by Ned Deily in branch 'default':
Issue bpo-21891: remove extraneous semicolon.
http://hg.python.org/cpython/rev/fc527ecb4487

@ned-deily
Copy link
Member

Thanks for the report!

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant