hashtable.c not using PY_FORMAT_SIZE_T

[JohnMalmberg]

BPO	21892
Nosy	@vstinner
Files	hashtable.gdiff: Patch to use PY_FORMAT_SIZE_T

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-07-01.06:58:06.312>
created_at = <Date 2014-07-01.04:59:13.103>
labels = []
title = 'hashtable.c not using PY_FORMAT_SIZE_T'
updated_at = <Date 2014-07-04.20:50:42.383>
user = 'https://bugs.python.org/JohnMalmberg'

bugs.python.org fields:

activity = <Date 2014-07-04.20:50:42.383>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-07-01.06:58:06.312>
closer = 'python-dev'
components = []
creation = <Date 2014-07-01.04:59:13.103>
creator = 'John.Malmberg'
dependencies = []
files = ['35811']
hgrepos = []
issue_num = 21892
keywords = []
message_count = 4.0
messages = ['222008', '222017', '222018', '222314']
nosy_count = 3.0
nosy_names = ['vstinner', 'python-dev', 'John.Malmberg']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21892'
versions = ['Python 3.5']

[JohnMalmberg]

hashtable.c is using %zd instead of the PY_FORMAT_SIZE_T as set by configure.

Comments in pymacconfig.h state that this will cause problems on OS-X 10.4 with binaries build on OS-X 10.5.

The attached patch hashtable.giff changes hashtable.c to be like the other modules that use PY_FORMAT_SIZE_T.

[python-dev]

New changeset 4f55e802baf0 by Victor Stinner in branch '3.4':
Closes bpo-21892, bpo-21893: Use PY_FORMAT_SIZE_T instead of %zi or %zu to format C
http://hg.python.org/cpython/rev/4f55e802baf0

New changeset 669b43bffd87 by Victor Stinner in branch 'default':
(Merge 3.4) Closes bpo-21892, bpo-21893: Use PY_FORMAT_SIZE_T instead of %zi or %zu
http://hg.python.org/cpython/rev/669b43bffd87

[vstinner]

Oh, I forgot the mention John Malmberg in the changelog, sorry :-(

Thanks for your fix John.

[python-dev]

New changeset 6fb1e2ce513a by Victor Stinner in branch '3.4':
Issue bpo-21892, bpo-21893: Partial revert of changeset 4f55e802baf0, PyErr_Format()
http://hg.python.org/cpython/rev/6fb1e2ce513a

New changeset 58cd562e3ef9 by Victor Stinner in branch 'default':
(Merge 3.4) Issue bpo-21892, bpo-21893: Partial revert of changeset 4f55e802baf0,
http://hg.python.org/cpython/rev/58cd562e3ef9