Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.hgignore: Missing ignores for downloaded doc build tools #66099

Closed
andy-maier mannequin opened this issue Jul 1, 2014 · 5 comments
Closed

.hgignore: Missing ignores for downloaded doc build tools #66099

andy-maier mannequin opened this issue Jul 1, 2014 · 5 comments

Comments

@andy-maier
Copy link
Mannequin

andy-maier mannequin commented Jul 1, 2014

BPO 21900
Nosy @bitdancer, @andy-maier
Files
  • issue21900.diff: Patch for Python 2.7 only.
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2014-07-01.18:34:40.937>
    created_at = <Date 2014-07-01.14:55:29.987>
    labels = ['invalid']
    title = '.hgignore: Missing ignores for downloaded doc build tools'
    updated_at = <Date 2014-07-02.16:13:46.142>
    user = 'https://github.com/andy-maier'

    bugs.python.org fields:

    activity = <Date 2014-07-02.16:13:46.142>
    actor = 'andymaier'
    assignee = 'none'
    closed = True
    closed_date = <Date 2014-07-01.18:34:40.937>
    closer = 'r.david.murray'
    components = []
    creation = <Date 2014-07-01.14:55:29.987>
    creator = 'andymaier'
    dependencies = []
    files = ['35818']
    hgrepos = []
    issue_num = 21900
    keywords = ['patch']
    message_count = 5.0
    messages = ['222041', '222054', '222101', '222104', '222111']
    nosy_count = 2.0
    nosy_names = ['r.david.murray', 'andymaier']
    pr_nums = []
    priority = 'normal'
    resolution = 'not a bug'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue21900'
    versions = ['Python 2.7']

    @andy-maier
    Copy link
    Mannequin Author

    andy-maier mannequin commented Jul 1, 2014

    In Python 2.7 and up to Python 3.3, the documentation build process downloads tools such as Sphinx etc. into the Doc/tools subtree. The .hgignore file misses entries to ignore those.

    The additional lines for .hgignore would be:
    ^Doc/tools/docutils/
    ^Doc/tools/jinja2/
    ^Doc/tools/pygments/
    ^Doc/tools/sphinx/

    This change applies to 2.7 only (assuming 3.1-3.3 are no longer patched).

    @bitdancer
    Copy link
    Member

    The entries are there for 2.7. And indeed for the 3.x versions to which they applied.

    @andy-maier
    Copy link
    Mannequin Author

    andy-maier mannequin commented Jul 2, 2014

    That is indeed true; i just verified that by creating a new clone repository. Sorry for the extra work.

    When I created the bug yesterday, I had my repository clone updated to "2.7" and the .hgignore definitely did not have the entries. I even saw all the downloaded doc tools in the status window of my hg client (which is what caused me to attempt to fix this in the first place).

    I did do a commit to my local repository clone but did not push that (I would not have the rights anyway).

    If anyone has an explanation on whyt I saw, I'd be grateful.

    Andy

    @bitdancer
    Copy link
    Member

    Are you sure your checkout was updated to 2.7? If you had checked out 2.7, built the docs, then checked out 3.4 and done an hg status, you would see the Doc files as untracked. If you were really checked out to 2.7 you shouldn't have. I doubt there's any way to figure out what went wrong unless you can reproduce it. Regardless, though, you are having a Mercurial issue here, not a Python one :)

    @andy-maier
    Copy link
    Mannequin Author

    andy-maier mannequin commented Jul 2, 2014

    Regardless, though, you are having a Mercurial issue here, not a Python one :)

    That seems to be the case ... I don't think I can reproduce it.

    All fine then.
    Thanks, David!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant