Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better path handling in Idle find in files #66159

Closed
terryjreedy opened this issue Jul 11, 2014 · 1 comment
Closed

Better path handling in Idle find in files #66159

terryjreedy opened this issue Jul 11, 2014 · 1 comment
Assignees
Labels
topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 21960
Nosy @terryjreedy
Superseder
  • bpo-36323: IDLE: always display full grep path
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
    closed_at = <Date 2019-03-20.13:04:55.650>
    created_at = <Date 2014-07-11.19:10:32.896>
    labels = ['expert-IDLE', 'type-feature']
    title = 'Better path handling in Idle find in files'
    updated_at = <Date 2019-03-20.15:50:44.858>
    user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2019-03-20.15:50:44.858>
    actor = 'terry.reedy'
    assignee = 'terry.reedy'
    closed = True
    closed_date = <Date 2019-03-20.13:04:55.650>
    closer = 'cheryl.sabella'
    components = ['IDLE']
    creation = <Date 2014-07-11.19:10:32.896>
    creator = 'terry.reedy'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 21960
    keywords = []
    message_count = 1.0
    messages = ['222779']
    nosy_count = 1.0
    nosy_names = ['terry.reedy']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '36323'
    type = 'enhancement'
    url = 'https://bugs.python.org/issue21960'
    versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

    @terryjreedy
    Copy link
    Member Author

    I propose two interrelated changes for path handling in Idle's Find in Files feature (Alt-F3).

    1. If I hit Alt-F3 in an editor window, the 'In files:' entry box displays a full path, such as "C:\Programs\Python34\Lib\idlelib\*.py". If I do the same in the shell, the display is "*.py" with the prefix, the starting directory containing pythonx.exe, suppressed. (In a repository build, the box is blank, perhaps because the executable is not in the directory containing Assuming 2, I would prefer the full path (in a wider dialog box).

    1a. In a repository build, the box is blank, perhaps because the executable is not in the directory containing Lib. Starting with the patch to that directory, rather than pcbuild (on Windows) would be more useful than nothing.

    1. FiF uses a generic Output Window. It first displays something like
      Searching 'Func' in lib/idlelib/idle_test/*.py ...
      where the path is copied from the 'In file:' path. This common prefix is displayed with all hits
      lib/idlelib/idle_test\htest.py: 15: or a wrapper function also work...
      lib/idlelib/idle_test\htest.py: 40: 'msg': "Test editor ...
      lib/idlelib/idle_test\mock_tk.py: 18: class Mbox_func:
      If one starts from the editor window, the common prefix is even longer and more noisy and obnoxious. (It is also slightly worse in my repository setup.)
      C:\Programs\Python34\lib/idlelib/idle_test\htest.py: 15: or a wrapper function also work...
      C:\Programs\Python34\lib/idlelib/idle_test\htest.py: 40: 'msg': "Test editor ...
      C:\Programs\Python34\lib/idlelib/idle_test\mock_tk.py: 18: class Mbox_func:
      which is why I do not especially want change 1 without change 2: delete the common prefix from the listing.
      htest.py: 15: or a wrapper function also work. The name of wrapper functions, like
      htest.py: 40: 'msg': "Test editor functions of interest"
      mock_tk.py: 18: class Mbox_func:
      The path prefix would have to be an attribute of the window, which should perhaps be an FiF subclass of OutputWindow anyway. The "Go to file/line" function would append the prefix.

    @terryjreedy terryjreedy added the type-feature A feature request or enhancement label Jul 11, 2014
    @terryjreedy terryjreedy self-assigned this Mar 20, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants