Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting suppress context manager to 2.7 #67114

Closed
BariaObradovi mannequin opened this issue Nov 23, 2014 · 2 comments
Closed

Backporting suppress context manager to 2.7 #67114

BariaObradovi mannequin opened this issue Nov 23, 2014 · 2 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@BariaObradovi
Copy link
Mannequin

BariaObradovi mannequin commented Nov 23, 2014

BPO 22925
Nosy @berkerpeksag
Files
  • suppress.patch: Patch to backport suppress context manager to 2.7
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2014-11-23.16:03:21.881>
    created_at = <Date 2014-11-23.15:50:17.533>
    labels = ['type-feature', 'library']
    title = 'Backporting suppress context manager to 2.7'
    updated_at = <Date 2014-11-23.16:34:14.947>
    user = 'https://bugs.python.org/BariaObradovi'

    bugs.python.org fields:

    activity = <Date 2014-11-23.16:34:14.947>
    actor = 'r.david.murray'
    assignee = 'none'
    closed = True
    closed_date = <Date 2014-11-23.16:03:21.881>
    closer = 'berker.peksag'
    components = ['Library (Lib)']
    creation = <Date 2014-11-23.15:50:17.533>
    creator = 'Bari\xc5\xa1a.Obradovi\xc4\x87'
    dependencies = []
    files = ['37253']
    hgrepos = ['280']
    issue_num = 22925
    keywords = ['patch']
    message_count = 2.0
    messages = ['231565', '231566']
    nosy_count = 2.0
    nosy_names = ['berker.peksag', 'Bari\xc5\xa1a.Obradovi\xc4\x87']
    pr_nums = []
    priority = 'normal'
    resolution = 'rejected'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue22925'
    versions = ['Python 2.7']

    @BariaObradovi
    Copy link
    Mannequin Author

    BariaObradovi mannequin commented Nov 23, 2014

    Backport one of the context manager in 3.4, to 2.7:
    supressed

    The patch was created by copy pasting code from 3.4 branch to 2.7 branch, and removing a single 3.4 feature:
    -@support.requires_docstrings

    @BariaObradovi BariaObradovi mannequin added build The build process and cross-build type-feature A feature request or enhancement labels Nov 23, 2014
    @berkerpeksag
    Copy link
    Member

    Thanks for the patch, but we don't backport new features to 2.7 unless they are related to PEP-434 and PEP-466. Please send your patch to https://bitbucket.org/ncoghlan/contextlib2

    @berkerpeksag berkerpeksag added stdlib Python modules in the Lib dir and removed build The build process and cross-build labels Nov 23, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant