Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python/importlib.h is now generated by Programs/_freeze_importlib.c, change comment #67123

Closed
crozzy mannequin opened this issue Nov 24, 2014 · 3 comments
Closed

Python/importlib.h is now generated by Programs/_freeze_importlib.c, change comment #67123

crozzy mannequin opened this issue Nov 24, 2014 · 3 comments
Assignees
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@crozzy
Copy link
Mannequin

crozzy mannequin commented Nov 24, 2014

BPO 22934
Nosy @berkerpeksag
Files
  • freeze_importlib_comment.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/berkerpeksag'
    closed_at = <Date 2014-11-24.21:27:02.574>
    created_at = <Date 2014-11-24.19:48:32.283>
    labels = ['type-feature', 'build']
    title = 'Python/importlib.h is now generated by Programs/_freeze_importlib.c, change comment'
    updated_at = <Date 2014-11-24.21:27:02.572>
    user = 'https://bugs.python.org/crozzy'

    bugs.python.org fields:

    activity = <Date 2014-11-24.21:27:02.572>
    actor = 'berker.peksag'
    assignee = 'berker.peksag'
    closed = True
    closed_date = <Date 2014-11-24.21:27:02.574>
    closer = 'berker.peksag'
    components = ['Build']
    creation = <Date 2014-11-24.19:48:32.283>
    creator = 'crozzy'
    dependencies = []
    files = ['37267']
    hgrepos = []
    issue_num = 22934
    keywords = ['patch']
    message_count = 3.0
    messages = ['231617', '231618', '231619']
    nosy_count = 3.0
    nosy_names = ['python-dev', 'berker.peksag', 'crozzy']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue22934'
    versions = ['Python 3.5']

    @crozzy
    Copy link
    Mannequin Author

    crozzy mannequin commented Nov 24, 2014

    Since the changeset 91853:88a532a31eb3 _freeze_importlib.c resides in the Programs dir. The header comment of Python/importlib.h should be changed to reflect this.

    @crozzy crozzy mannequin added the build The build process and cross-build label Nov 24, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 24, 2014

    New changeset 0ddcc455e001 by Berker Peksag in branch 'default':
    Issue bpo-22934: Update the comment to mention Programs/_freeze_importlib.c.
    https://hg.python.org/cpython/rev/0ddcc455e001

    @berkerpeksag
    Copy link
    Member

    Thanks for the patch, Joseph.

    @berkerpeksag berkerpeksag self-assigned this Nov 24, 2014
    @berkerpeksag berkerpeksag added the type-feature A feature request or enhancement label Nov 24, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant