Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak wording for importlib.util.LazyLoader in regards to Loader.create_module() #67202

Closed
brettcannon opened this issue Dec 8, 2014 · 3 comments
Assignees
Labels
docs Documentation in the Doc dir easy

Comments

@brettcannon
Copy link
Member

BPO 23013
Nosy @brettcannon
Dependencies
  • bpo-23014: Don't have importlib.abc.Loader.create_module() be optional
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
    closed_at = <Date 2015-01-16.13:42:27.432>
    created_at = <Date 2014-12-08.16:09:14.768>
    labels = ['easy', 'docs']
    title = 'Tweak wording for importlib.util.LazyLoader in regards to Loader.create_module()'
    updated_at = <Date 2015-01-16.13:42:27.431>
    user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2015-01-16.13:42:27.431>
    actor = 'brett.cannon'
    assignee = 'brett.cannon'
    closed = True
    closed_date = <Date 2015-01-16.13:42:27.432>
    closer = 'brett.cannon'
    components = ['Documentation']
    creation = <Date 2014-12-08.16:09:14.768>
    creator = 'brett.cannon'
    dependencies = ['23014']
    files = []
    hgrepos = []
    issue_num = 23013
    keywords = ['easy']
    message_count = 3.0
    messages = ['232312', '232564', '234128']
    nosy_count = 1.0
    nosy_names = ['brett.cannon']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'needs patch'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue23013'
    versions = ['Python 3.5']

    @brettcannon
    Copy link
    Member Author

    The docs for importlib.util.LazyLoader emphatically say that a "loader cannot define importlib.abc.Loader.create_module()" if it is to be subclassed. What in fact should say is that the subclass' create_module() will not be called; whether it is defined or not is of no consequence.

    @brettcannon brettcannon self-assigned this Dec 8, 2014
    @brettcannon brettcannon added docs Documentation in the Doc dir easy labels Dec 8, 2014
    @brettcannon
    Copy link
    Member Author

    Fix is part of issue bpo-23014, so if that goes in then this will be fixed as a side-effect.

    @brettcannon
    Copy link
    Member Author

    Change went in through making create_module() required.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir easy
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant