Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect that PreReq and BuildPreReq are deprecated in the latest RPM #67358

Closed
radeksimko mannequin opened this issue Jan 5, 2015 · 2 comments
Closed

Reflect that PreReq and BuildPreReq are deprecated in the latest RPM #67358

radeksimko mannequin opened this issue Jan 5, 2015 · 2 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@radeksimko
Copy link
Mannequin

radeksimko mannequin commented Jan 5, 2015

BPO 23169
Nosy @benjaminp

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-02-18.14:02:41.829>
created_at = <Date 2015-01-05.13:18:11.641>
labels = ['type-feature', 'build']
title = 'Reflect that PreReq and BuildPreReq are deprecated in the latest RPM'
updated_at = <Date 2015-02-18.14:02:41.827>
user = 'https://bugs.python.org/radeksimko'

bugs.python.org fields:

activity = <Date 2015-02-18.14:02:41.827>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2015-02-18.14:02:41.829>
closer = 'benjamin.peterson'
components = ['Build']
creation = <Date 2015-01-05.13:18:11.641>
creator = 'radeksimko'
dependencies = []
files = []
hgrepos = []
issue_num = 23169
keywords = []
message_count = 2.0
messages = ['233462', '236173']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'radeksimko']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23169'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4', 'Python 3.5', 'Python 3.6']

@radeksimko
Copy link
Mannequin Author

radeksimko mannequin commented Jan 5, 2015

When I try to make custom package of Python 2.7, I use the spec file attached in /Misc/RPM. I don't really use it to build Python as I want to define some specific options, but I do use it as a source of RPM package meta data which I can simply reuse when creating the final RPM, e.g.:

rpm -q --specfile ./Misc/RPM/python-2.7.spec --queryformat '%{DESCRIPTION}'

Manipulation with that specfile in RPM 4.4.2.3 (CentOS 5.6) is fine, but there are warnings in RPM 4.8.0 (CentOS 6.5):

warning: line 71: buildprereq is deprecated: BuildPrereq: expat-devel
warning: line 72: buildprereq is deprecated: BuildPrereq: db4-devel
warning: line 73: buildprereq is deprecated: BuildPrereq: gdbm-devel
warning: line 74: buildprereq is deprecated: BuildPrereq: sqlite-devel
warning: line 91: prereq is deprecated: Prereq: python2.6 = %{PACKAGE_VERSION}
warning: line 122: prereq is deprecated: Prereq: python2.6 = %{PACKAGE_VERSION}-1pydotorg

Here's related thread: https://groups.google.com/forum/#!topic/comp.lang.python/R8ahiZ5wyhc
and most importantly here's proof/explanation: http://www.rpm.org/wiki/Releases/4.8.0#Packagebuilding

  • PreReq and BuildPreReq are now officially deprecated, with warnings at build-time
  • PreReq is mapped to Requires(pre,preun) at build-time

Requires(pre,preun) is backwards compatible, so it works in RPM 4.4 too, I would therefore suggest to change "[Build]Prereq" to "[Build]Requires(pre,preun)" respectively in the specfile to reflect this.

I'm happy to send a patch if some maintainers will agree with proposed solution.

@radeksimko radeksimko mannequin added build The build process and cross-build type-feature A feature request or enhancement labels Jan 5, 2015
@benjaminp
Copy link
Contributor

We just deleted the spec file.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant