Unused Superclass in calendar.py

[CliffM]

BPO	23304
Nosy	@berkerpeksag, @serhiy-storchaka
Files	calendar_1.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-02-28.09:22:10.286>
created_at = <Date 2015-01-22.21:46:50.237>
labels = ['easy', 'tests', 'library', 'invalid']
title = 'Unused Superclass in calendar.py'
updated_at = <Date 2015-02-28.17:04:44.140>
user = 'https://bugs.python.org/CliffM'

bugs.python.org fields:

activity = <Date 2015-02-28.17:04:44.140>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2015-02-28.09:22:10.286>
closer = 'serhiy.storchaka'
components = ['Library (Lib)', 'Tests']
creation = <Date 2015-01-22.21:46:50.237>
creator = 'CliffM'
dependencies = []
files = ['37891']
hgrepos = []
issue_num = 23304
keywords = ['patch', 'easy']
message_count = 4.0
messages = ['234513', '234895', '234915', '234917']
nosy_count = 4.0
nosy_names = ['berker.peksag', 'serhiy.storchaka', 'CliffM', 'Vipul.Sharma']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue23304'
versions = ['Python 3.5']

[CliffM]

calendar.py ( lines 17,18 ) is not used :

# Exception raised for bad input (with string parameter for details)
error = ValueError

This could either be deleted OR used as the superclass in the next two class declarations as the comment suggests.

[VipulSharma]

I am submitting a patch file, hope this works. Please review it and correct me if I am wrong anywhere as this is my first contribution.

[berkerpeksag]

Looks like "error" was unused since https://hg.python.org/cpython/rev/acdc0b9a6c78#l2.48 (see also https://hg.python.org/cpython/rev/6ee380349c84/ for time.gmtime()). LGTM.

[serhiy-storchaka]

I suppose that calendar.error is here for compatibility. It is an alias to ValueError, so that errors raised by the calendar module can be catched with the "except calendar.error:" statement. Making calendar.error different class will likely break user code. I am inclined to reject this patch.