Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie.domain is undocumented #67850

Closed
mhsmith mannequin opened this issue Mar 14, 2015 · 3 comments
Closed

Cookie.domain is undocumented #67850

mhsmith mannequin opened this issue Mar 14, 2015 · 3 comments
Labels
docs Documentation in the Doc dir easy type-feature A feature request or enhancement

Comments

@mhsmith
Copy link
Mannequin

mhsmith mannequin commented Mar 14, 2015

BPO 23662
Nosy @berkerpeksag, @vadmium, @demianbrecht, @mhsmith

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-04-25.11:35:20.114>
created_at = <Date 2015-03-14.15:01:20.241>
labels = ['easy', 'type-feature', 'docs']
title = 'Cookie.domain is undocumented'
updated_at = <Date 2016-04-25.11:35:20.112>
user = 'https://github.com/mhsmith'

bugs.python.org fields:

activity = <Date 2016-04-25.11:35:20.112>
actor = 'berker.peksag'
assignee = 'docs@python'
closed = True
closed_date = <Date 2016-04-25.11:35:20.114>
closer = 'berker.peksag'
components = ['Documentation']
creation = <Date 2015-03-14.15:01:20.241>
creator = 'Malcolm Smith'
dependencies = []
files = []
hgrepos = []
issue_num = 23662
keywords = ['easy']
message_count = 3.0
messages = ['238087', '264170', '264171']
nosy_count = 6.0
nosy_names = ['docs@python', 'python-dev', 'berker.peksag', 'martin.panter', 'demian.brecht', 'Malcolm Smith']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23662'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

@mhsmith
Copy link
Mannequin Author

mhsmith mannequin commented Mar 14, 2015

This is a fundamental attribute of a cookie, which will be set even if the server doesn't specify it, yet it doesn't appear in the documentation either of 2.x cookielib or 3.x http.cookiejar.

@mhsmith mhsmith mannequin assigned docspython Mar 14, 2015
@mhsmith mhsmith mannequin added the docs Documentation in the Doc dir label Mar 14, 2015
@berkerpeksag berkerpeksag added easy type-feature A feature request or enhancement labels Apr 25, 2016
@python-dev
Copy link
Mannequin

python-dev mannequin commented Apr 25, 2016

New changeset 1fdaa71d47f5 by Berker Peksag in branch '3.5':
Issue bpo-23662: Document default value of RFC 2109 attributes
https://hg.python.org/cpython/rev/1fdaa71d47f5

New changeset b3ad9c002bb8 by Berker Peksag in branch 'default':
Issue bpo-23662: Document default value of RFC 2109 attributes
https://hg.python.org/cpython/rev/b3ad9c002bb8

@berkerpeksag
Copy link
Member

Actually, it's already documented at https://docs.python.org/3.5/library/http.cookies.html#http.cookies.Morsel. I just added a note about the default value of domain.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir easy type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant