Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document return value for ZipFile.extract() #67918

Closed
mjpieters mannequin opened this issue Mar 21, 2015 · 4 comments
Closed

Document return value for ZipFile.extract() #67918

mjpieters mannequin opened this issue Mar 21, 2015 · 4 comments
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@mjpieters
Copy link
Mannequin

mjpieters mannequin commented Mar 21, 2015

BPO 23730
Nosy @mjpieters, @zware, @matrixise
Files
  • issue23730.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2015-04-13.21:44:17.787>
    created_at = <Date 2015-03-21.09:11:29.417>
    labels = ['type-feature', 'docs']
    title = 'Document return value for ZipFile.extract()'
    updated_at = <Date 2015-04-13.21:46:02.155>
    user = 'https://github.com/mjpieters'

    bugs.python.org fields:

    activity = <Date 2015-04-13.21:46:02.155>
    actor = 'zach.ware'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2015-04-13.21:44:17.787>
    closer = 'python-dev'
    components = ['Documentation']
    creation = <Date 2015-03-21.09:11:29.417>
    creator = 'mjpieters'
    dependencies = []
    files = ['38943']
    hgrepos = []
    issue_num = 23730
    keywords = ['patch']
    message_count = 4.0
    messages = ['238778', '240687', '240770', '240771']
    nosy_count = 5.0
    nosy_names = ['mjpieters', 'docs@python', 'python-dev', 'zach.ware', 'matrixise']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue23730'
    versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

    @mjpieters
    Copy link
    Mannequin Author

    mjpieters mannequin commented Mar 21, 2015

    The documentation for zipfile.ZipFile.extract() doesn't mention at all that it returns the local path created, either for the directory that the member represents, or the new file created from the zipped data.

    *Returns the full local path created (a directory or new file)* or similar.

    @mjpieters mjpieters mannequin assigned docspython Mar 21, 2015
    @mjpieters mjpieters mannequin added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Mar 21, 2015
    @matrixise
    Copy link
    Member

    fix for the documentation of ZipFile.extract.

    In the code of _extract_member, there is a normalisation of the target path, I use this term "normalized" for the fix.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 13, 2015

    New changeset 731e366885f5 by Zachary Ware in branch '2.7':
    Issue bpo-23730: Document the return value of ZipFile.extract
    https://hg.python.org/cpython/rev/731e366885f5

    New changeset 7ac1c2307a70 by Zachary Ware in branch '3.4':
    Issue bpo-23730: Document the return value of ZipFile.extract
    https://hg.python.org/cpython/rev/7ac1c2307a70

    New changeset d958c74ddb0c by Zachary Ware in branch 'default':
    Closes bpo-23730: merge with 3.4
    https://hg.python.org/cpython/rev/d958c74ddb0c

    @python-dev python-dev mannequin closed this as completed Apr 13, 2015
    @zware
    Copy link
    Member

    zware commented Apr 13, 2015

    Thanks for the patch!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants