remove_module() needs to save/restore exception state

[opensdh]

BPO	24048
Nosy	@ncoghlan, @ericsnowcurrently, @opensdh, @ZackerySpytz, @miss-islington
PRs	bpo-24048: Save the live exception during import.c's remove_module() #13005 [3.7] bpo-24048: Save the live exception during import.c's remove_module() (GH-13005) #20521

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ncoghlan'
closed_at = <Date 2020-06-28.06:52:49.426>
created_at = <Date 2015-04-24.05:58:38.623>
labels = ['interpreter-core', '3.8', 'type-bug', '3.7']
title = 'remove_module() needs to save/restore exception state'
updated_at = <Date 2020-06-28.06:52:49.425>
user = 'https://github.com/opensdh'

bugs.python.org fields:

activity = <Date 2020-06-28.06:52:49.425>
actor = 'ncoghlan'
assignee = 'ncoghlan'
closed = True
closed_date = <Date 2020-06-28.06:52:49.426>
closer = 'ncoghlan'
components = ['Interpreter Core']
creation = <Date 2015-04-24.05:58:38.623>
creator = 'herring'
dependencies = []
files = []
hgrepos = []
issue_num = 24048
keywords = ['patch']
message_count = 9.0
messages = ['241914', '341063', '341905', '342428', '342430', '370329', '370335', '370497', '372498']
nosy_count = 5.0
nosy_names = ['ncoghlan', 'eric.snow', 'herring', 'ZackerySpytz', 'miss-islington']
pr_nums = ['13005', '20521']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24048'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8']

[opensdh]

import.c's remove_module() is always called with an exception set and can invoke arbitrary code via deallocation; if that code calls PyErr_Clear() (or is sensitive to PyErr_Occurred()) it will lose (or be damaged by) the preexisting exception.

[ZackerySpytz]

I've created a PR for this issue.

[ncoghlan]

New changeset 94a64e9 by Nick Coghlan (Zackery Spytz) in branch 'master':
bpo-24048: Save the live exception during import.c's remove_module() (GH-13005)
94a64e9

[brettcannon]

Can this be closed, Nick?

[ZackerySpytz]

I think this change should be backported.

[brettcannon]

Assigning to Nick to decide if he wants to backport it to 3.7 before it's no longer possible.

[miss-islington]

New changeset 5aa40e5 by Miss Islington (bot) in branch '3.7':
bpo-24048: Save the live exception during import.c's remove_module() (GH-13005)
5aa40e5

[ZackerySpytz]

It seems that Serhiy backported the fix.

[ncoghlan]

Belatedly marking this as resolved.