Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python27 unicode align comments #68764

Closed
ghost opened this issue Jul 6, 2015 · 2 comments
Closed

python27 unicode align comments #68764

ghost opened this issue Jul 6, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 6, 2015

BPO 24576
Nosy @vstinner, @ned-deily, @ezio-melotti
Files
  • python27_unicode_align_comments.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2015-07-06.20:33:56.870>
    created_at = <Date 2015-07-06.13:23:58.222>
    labels = ['expert-unicode']
    title = 'python27 unicode align comments'
    updated_at = <Date 2015-07-06.20:33:56.868>
    user = None

    bugs.python.org fields:

    activity = <Date 2015-07-06.20:33:56.868>
    actor = 'ned.deily'
    assignee = 'none'
    closed = True
    closed_date = <Date 2015-07-06.20:33:56.870>
    closer = 'ned.deily'
    components = ['Unicode']
    creation = <Date 2015-07-06.13:23:58.222>
    creator = '\xe6\xbd\x98\xe6\x96\xb0\xe6\x98\x8e'
    dependencies = []
    files = ['39875']
    hgrepos = []
    issue_num = 24576
    keywords = ['patch']
    message_count = 2.0
    messages = ['246360', '246380']
    nosy_count = 4.0
    nosy_names = ['vstinner', 'ned.deily', 'ezio.melotti', '\xe6\xbd\x98\xe6\x96\xb0\xe6\x98\x8e']
    pr_nums = []
    priority = 'normal'
    resolution = 'wont fix'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue24576'
    versions = ['Python 2.7']

    @ghost
    Copy link
    Author

    ghost commented Jul 6, 2015

    see patch.

    Repository owner added the topic-unicode label Jul 6, 2015
    @ned-deily
    Copy link
    Member

    Thanks for the patch. However, in general, we don't like to change the source files in Python just to improve white-space formatting, in particular with older releases like Python 2.7. If the formatting changes are being done as part of a larger change in the area, sure, but otherwise it's a judgement call and we usually avoid unnecessary churn in maintenance releases.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants