test_ssl: try more protocols in test_options()

[marcosptf]

BPO	24930
Nosy	@tiran, @bitdancer, @vadmium
Files	test_options.patch: test fixed from test_ssl.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-09-08.15:39:40.221>
created_at = <Date 2015-08-24.23:18:03.689>
labels = ['type-feature', 'tests']
title = 'test_ssl: try more protocols in test_options()'
updated_at = <Date 2016-09-08.15:39:40.219>
user = 'https://bugs.python.org/marcosptf'

bugs.python.org fields:

activity = <Date 2016-09-08.15:39:40.219>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2016-09-08.15:39:40.221>
closer = 'christian.heimes'
components = ['Tests']
creation = <Date 2015-08-24.23:18:03.689>
creator = 'marcosptf'
dependencies = []
files = ['40249']
hgrepos = []
issue_num = 24930
keywords = ['patch']
message_count = 6.0
messages = ['249078', '249094', '249096', '249097', '258774', '275053']
nosy_count = 4.0
nosy_names = ['christian.heimes', 'r.david.murray', 'martin.panter', 'marcosptf']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'patch review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue24930'
versions = ['Python 2.7']

[marcosptf]

Hello to everyone!!!

This test https://hg.python.org/cpython/file/2.7/Lib/test/test_ssl.py on method
ContextTests.test_options, is broker becouse has a error between lines 717 ~ 719;

On 717 line, has a comment about # OP_ALL | OP_NO_SSLv2 is the default value, but
it's not true, becouse this method is fail when i run it =>
py.test Lib/test/test_ssl.py -k ContextTests
results ===>
https://hg.python.org/cpython/file/2.7/Lib/test/test_ssl.py#l717
*** AssertionError: 2164261887 != 2197816319L

I fixed this method and i wrote new cases about test_options using a lot of options
from ssl.PROTOCOL, for example:
ssl.PROTOCOL_TLSv1
ssl.PROTOCOL_TLSv1_1
ssl.PROTOCOL_TLSv1_2
ssl.PROTOCOL_SSLv2
ssl.PROTOCOL_SSLv23
ssl.PROTOCOL_SSLv3

on this test_options.patch, is the test fixed!

thanks
Att

:-)
marcosptf

[bitdancer]

Most likely you ran the test using a different version of python from the one the test is from. All the tests in that file pass on our buildbots when run by the python version they are for.

[marcosptf]

the version that i ran the test, is python 2.7.10

[marcosptf]

anyway, this changes that i did, make this test more resilent!
this test now is more complete than before!

:-)

[vadmium]

Your patch removes the testing of getting ctx.options. However, OP_NO_SSLv3 was enabled by default and added to the test in bpo-25530, so I suspect that problem is no longer valid.

I guess that leaves the rest of your patch which exercises other protocol values.

[tiran]

This ticket is no longer relevant. All but TLS_METHOD (old name SSLv23_METHOD) have been deprecated by OpenSSL. In the future Python will use auto-negotiation.