Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing periods at the end of sentences #69348

Closed
artakase mannequin opened this issue Sep 18, 2015 · 8 comments
Closed

Missing periods at the end of sentences #69348

artakase mannequin opened this issue Sep 18, 2015 · 8 comments
Assignees
Labels
docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@artakase
Copy link
Mannequin

artakase mannequin commented Sep 18, 2015

BPO 25161
Nosy @terryjreedy, @berkerpeksag, @vadmium
Files
  • periods.patch
  • periods-2.7.patch
  • periods_v2.patch
  • periods-2.7_v2.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/vadmium'
    closed_at = <Date 2015-10-10.11:41:53.599>
    created_at = <Date 2015-09-18.07:21:30.216>
    labels = ['type-bug', 'docs']
    title = 'Missing periods at the end of sentences'
    updated_at = <Date 2015-10-10.11:41:53.597>
    user = 'https://bugs.python.org/artakase'

    bugs.python.org fields:

    activity = <Date 2015-10-10.11:41:53.597>
    actor = 'martin.panter'
    assignee = 'martin.panter'
    closed = True
    closed_date = <Date 2015-10-10.11:41:53.599>
    closer = 'martin.panter'
    components = ['Documentation']
    creation = <Date 2015-09-18.07:21:30.216>
    creator = 'artakase'
    dependencies = []
    files = ['40498', '40499', '40718', '40720']
    hgrepos = []
    issue_num = 25161
    keywords = ['patch']
    message_count = 8.0
    messages = ['250951', '250952', '251056', '252548', '252551', '252705', '252707', '252709']
    nosy_count = 6.0
    nosy_names = ['terry.reedy', 'docs@python', 'python-dev', 'berker.peksag', 'martin.panter', 'artakase']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue25161'
    versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']

    @artakase
    Copy link
    Mannequin Author

    artakase mannequin commented Sep 18, 2015

    The attached patch adds some periods in docs.
    This applies to 3.x.

    @artakase artakase mannequin assigned docspython Sep 18, 2015
    @artakase artakase mannequin added docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error labels Sep 18, 2015
    @artakase
    Copy link
    Mannequin Author

    artakase mannequin commented Sep 18, 2015

    Added patch for 2.7.

    @vadmium
    Copy link
    Member

    vadmium commented Sep 19, 2015

    All the changes in the non-2.7 patch look reasonable to me. I left two review comments suggesting a few extra minor edits.

    @artakase
    Copy link
    Mannequin Author

    artakase mannequin commented Oct 8, 2015

    Thank you for reviewing.

    This is an updated patch for 3.x.

    @artakase
    Copy link
    Mannequin Author

    artakase mannequin commented Oct 8, 2015

    And this is an updated patch for 2.7.

    @vadmium vadmium assigned vadmium and unassigned docspython Oct 10, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 10, 2015

    New changeset 4dfead9635e5 by Martin Panter in branch '3.4':
    Issue bpo-25161: Add full stops in documentation; patch by Takase Arihiro
    https://hg.python.org/cpython/rev/4dfead9635e5

    New changeset be34d96e2184 by Martin Panter in branch '3.5':
    Issue bpo-25161: Merge full stops from 3.4 into 3.5
    https://hg.python.org/cpython/rev/be34d96e2184

    New changeset fe87a6f9caa7 by Martin Panter in branch 'default':
    Issue bpo-25161: Merge full stops from 3.5
    https://hg.python.org/cpython/rev/fe87a6f9caa7

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 10, 2015

    New changeset b9a0ecae02cb by Martin Panter in branch '2.7':
    Issue bpo-25161: Add full stops in documentation; patch by Takase Arihiro
    https://hg.python.org/cpython/rev/b9a0ecae02cb

    @vadmium
    Copy link
    Member

    vadmium commented Oct 10, 2015

    Thanks very much for the patches.

    @vadmium vadmium closed this as completed Oct 10, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant