Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate _verbose_message in importlib._bootstrap and _bootstrap_external #69373

Closed
brettcannon opened this issue Sep 19, 2015 · 3 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@brettcannon
Copy link
Member

BPO 25186
Nosy @brettcannon, @ericsnowcurrently

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-09-25.20:05:38.605>
created_at = <Date 2015-09-19.23:02:11.990>
labels = ['type-feature', 'library']
title = "Don't duplicate _verbose_message in importlib._bootstrap and _bootstrap_external"
updated_at = <Date 2015-09-25.20:05:38.604>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2015-09-25.20:05:38.604>
actor = 'brett.cannon'
assignee = 'none'
closed = True
closed_date = <Date 2015-09-25.20:05:38.605>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2015-09-19.23:02:11.990>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 25186
keywords = []
message_count = 3.0
messages = ['251124', '251309', '251602']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'Arfrever', 'python-dev', 'eric.snow']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25186'
versions = ['Python 3.6']

@brettcannon
Copy link
Member Author

For some reason _verbose_message() is defined in both _bootstrap and _bootstrap_external. Probably should only have it in _bootstrap, unless Eric has a reason he duplicated the code.

@brettcannon brettcannon added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Sep 19, 2015
@ericsnowcurrently
Copy link
Member

I'm fairly sure this was just an oversight on my part.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Sep 25, 2015

New changeset 1266e98fd04c by Brett Cannon in branch 'default':
Issue bpo-25186: Remove duplicated function from importlib._bootstrap_external
https://hg.python.org/cpython/rev/1266e98fd04c

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants