test_venv fails with --without-threads

[Arfrever]

BPO	25366
Nosy	@vsajip, @ncoghlan, @berkerpeksag, @dstufft

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-01-19.00:03:51.747>
created_at = <Date 2015-10-10.16:26:58.545>
labels = ['type-bug', 'tests']
title = 'test_venv fails with --without-threads'
updated_at = <Date 2016-01-19.00:03:51.745>
user = 'https://bugs.python.org/Arfrever'

bugs.python.org fields:

activity = <Date 2016-01-19.00:03:51.745>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-01-19.00:03:51.747>
closer = 'berker.peksag'
components = ['Tests']
creation = <Date 2015-10-10.16:26:58.545>
creator = 'Arfrever'
dependencies = []
files = []
hgrepos = []
issue_num = 25366
keywords = []
message_count = 3.0
messages = ['252725', '258562', '258563']
nosy_count = 6.0
nosy_names = ['vinay.sajip', 'ncoghlan', 'Arfrever', 'python-dev', 'berker.peksag', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25366'
versions = ['Python 3.5', 'Python 3.6']

[Arfrever]

test.test_venv.EnsurePipTest.test_with_pip() fails with --without-threads, because some dependencies of PIP (cachecontrol, lockfile) unconditionally import threading module.

======================================================================
FAIL: test_with_pip (test.test_venv.EnsurePipTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/tmp/cpython/Lib/test/test_venv.py", line 356, in test_with_pip
    with_pip=True)
subprocess.CalledProcessError: Command '['/tmp/tmpgt_wdmiq/bin/python', '-Im', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/tmp/cpython/Lib/test/test_venv.py", line 362, in test_with_pip
    self.fail(msg.format(exc, details))
AssertionError: Command '['/tmp/tmpgt_wdmiq/bin/python', '-Im', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1

**Subprocess Output**
Traceback (most recent call last):
  File "/tmp/cpython/Lib/runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "/tmp/cpython/Lib/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmp/cpython/Lib/ensurepip/__main__.py", line 4, in <module>
    ensurepip._main()
  File "/tmp/cpython/Lib/ensurepip/__init__.py", line 209, in _main
    default_pip=args.default_pip,
  File "/tmp/cpython/Lib/ensurepip/__init__.py", line 116, in bootstrap
    _run_pip(args + [p[0] for p in _PROJECTS], additional_paths)
  File "/tmp/cpython/Lib/ensurepip/__init__.py", line 40, in _run_pip
    import pip
  File "/tmp/tmp1bl0s_61/pip-7.1.2-py2.py3-none-any.whl/pip/__init__.py", line 15, in <module>
  File "/tmp/tmp1bl0s_61/pip-7.1.2-py2.py3-none-any.whl/pip/vcs/mercurial.py", line 10, in <module>
  File "/tmp/tmp1bl0s_61/pip-7.1.2-py2.py3-none-any.whl/pip/download.py", line 44, in <module>
  File "/tmp/tmp1bl0s_61/pip-7.1.2-py2.py3-none-any.whl/pip/_vendor/cachecontrol/__init__.py", line 9, in <module>
  File "/tmp/tmp1bl0s_61/pip-7.1.2-py2.py3-none-any.whl/pip/_vendor/cachecontrol/wrapper.py", line 1, in <module>
  File "/tmp/tmp1bl0s_61/pip-7.1.2-py2.py3-none-any.whl/pip/_vendor/cachecontrol/adapter.py", line 5, in <module>
  File "/tmp/tmp1bl0s_61/pip-7.1.2-py2.py3-none-any.whl/pip/_vendor/cachecontrol/controller.py", line 11, in <module>
  File "/tmp/tmp1bl0s_61/pip-7.1.2-py2.py3-none-any.whl/pip/_vendor/cachecontrol/cache.py", line 5, in <module>
  File "/tmp/cpython/Lib/threading.py", line 4, in <module>
    import _thread
ImportError: No module named '_thread'

---

[python-dev]

New changeset 2a201272daed by Berker Peksag in branch '3.5':
Issue bpo-25366: Skip test_with_pip when threading module is not available
https://hg.python.org/cpython/rev/2a201272daed

New changeset 27d4f06c3720 by Berker Peksag in branch 'default':
Issue bpo-25366: Skip test_with_pip when threading module is not available
https://hg.python.org/cpython/rev/27d4f06c3720

[berkerpeksag]

Fixed. Thanks for the report, Arfrever