Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftplib docs language fix #69875

Closed
SilentGhost mannequin opened this issue Nov 21, 2015 · 3 comments
Closed

ftplib docs language fix #69875

SilentGhost mannequin opened this issue Nov 21, 2015 · 3 comments
Labels
docs Documentation in the Doc dir

Comments

@SilentGhost
Copy link
Mannequin

SilentGhost mannequin commented Nov 21, 2015

BPO 25689
Nosy @vadmium
Files
  • ftplib_docs.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2015-11-21.23:06:27.881>
    created_at = <Date 2015-11-21.12:35:52.708>
    labels = ['docs']
    title = 'ftplib docs language fix'
    updated_at = <Date 2015-11-21.23:06:27.880>
    user = 'https://bugs.python.org/SilentGhost'

    bugs.python.org fields:

    activity = <Date 2015-11-21.23:06:27.880>
    actor = 'martin.panter'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2015-11-21.23:06:27.881>
    closer = 'martin.panter'
    components = ['Documentation']
    creation = <Date 2015-11-21.12:35:52.708>
    creator = 'SilentGhost'
    dependencies = []
    files = ['41112']
    hgrepos = []
    issue_num = 25689
    keywords = ['patch']
    message_count = 3.0
    messages = ['255056', '255074', '255075']
    nosy_count = 4.0
    nosy_names = ['SilentGhost', 'docs@python', 'python-dev', 'martin.panter']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue25689'
    versions = ['Python 3.4', 'Python 3.5', 'Python 3.6']

    @SilentGhost
    Copy link
    Mannequin Author

    SilentGhost mannequin commented Nov 21, 2015

    Just a minor fix, removing the following: "Here is a sample on how using it:"

    @SilentGhost SilentGhost mannequin assigned docspython Nov 21, 2015
    @SilentGhost SilentGhost mannequin added the docs Documentation in the Doc dir label Nov 21, 2015
    @vadmium
    Copy link
    Member

    vadmium commented Nov 21, 2015

    Thanks for the patch, I will commit it.

    I also noticed the same problem in nntplib. And I think the sentence works even better starting as “The FTP class supports . . .”.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 21, 2015

    New changeset 74111e62a76c by Martin Panter in branch '3.4':
    Issue bpo-25689: Fix language in ftplib and nntplib docs
    https://hg.python.org/cpython/rev/74111e62a76c

    New changeset 2fa12e53e8f3 by Martin Panter in branch '3.5':
    Issue bpo-25689: Merge ftplib and nntplib docs from 3.4 into 3.5
    https://hg.python.org/cpython/rev/2fa12e53e8f3

    New changeset b99a30383bd5 by Martin Panter in branch 'default':
    Issue bpo-25689: Merge ftplib and nntplib docs from 3.5
    https://hg.python.org/cpython/rev/b99a30383bd5

    @vadmium vadmium closed this as completed Nov 21, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant