Launcher fails to find in-place built binaries from earlier Python versions

[mhammond]

BPO	26070
Nosy	@mhammond, @pfmoore, @vsajip, @tjguk, @zware, @zooba
Files	launcher.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/mhammond'
closed_at = <Date 2016-01-16.21:50:37.296>
created_at = <Date 2016-01-10.00:59:35.199>
labels = ['type-bug', 'OS-windows']
title = 'Launcher fails to find in-place built binaries from earlier Python versions'
updated_at = <Date 2016-01-16.21:50:37.295>
user = 'https://github.com/mhammond'

bugs.python.org fields:

activity = <Date 2016-01-16.21:50:37.295>
actor = 'steve.dower'
assignee = 'mhammond'
closed = True
closed_date = <Date 2016-01-16.21:50:37.296>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2016-01-10.00:59:35.199>
creator = 'mhammond'
dependencies = []
files = ['41560']
hgrepos = []
issue_num = 26070
keywords = ['patch']
message_count = 6.0
messages = ['257878', '257886', '257897', '257902', '257917', '257949']
nosy_count = 7.0
nosy_names = ['mhammond', 'paul.moore', 'vinay.sajip', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26070'
versions = ['Python 3.5', 'Python 3.6']

[mhammond]

The launcher was recently updated to look in PCBuild/win32 to support the win32 binaries being built in this directory instead of the top-level PCBuild directory. However, when this new launcher tries to find a binary for, say, Python 2.7, it doesn't find an executable because it's directly in PCBuild, not one of the win32 or amd64 sub-directories.

Note this only impacts Python when it is built in the directory - it doesn't impact installed versions.

The fix I came up with is to continue looking in PCBuild if it isn't found in one of those dirs.

Vinay, what do you think?

[zooba]

I don't think Vinay does much wrt the launcher in core anymore, it's mostly been me recently.

I don't see any harm in this change, though I'll admit I also don't see the point. When is the launcher ever going to find Python built in-place?

[mhammond]

When is the launcher ever going to find Python built in-place?

On the machine that built Python in-place :) I have a dev environment where all Python versions and pywin32 are built and that's the environment where py.exe is failing. My build scripts use py.exe to build for a specific Python version.

It sounds like you are fine with it, so I'll try and work out how to get a new key up and push it unless I hear otherwise, thanks.

[vsajip]

Hey, Steve, don't shut me out, I'm still here ;-)

I've had a heavy consulting load for the past year or so which means I can't always deal with issues as quickly as before. If someone else fixes issues before I get to them, it's fine by me :-)

IMO the proposed change by Mark seems reasonable. It's really only for us devs anyway.

[zooba]

I've had a heavy consulting load for the past year or so which means I can't always deal with issues as quickly as before.

That explains it :) With so little visibility into what we're doing outside of Python it's hard to know. Glad you're still about.

[python-dev]

New changeset 51cc7adac78d by Mark Hammond in branch '3.5':
Issue bpo-26070: py.exe launcher fails to find in-place built binaries from earlier Python versions.
https://hg.python.org/cpython/rev/51cc7adac78d

New changeset bfb4a09149b1 by Mark Hammond in branch 'default':
Issue bpo-26070: py.exe launcher fails to find in-place built binaries from earlier Python versions.
https://hg.python.org/cpython/rev/bfb4a09149b1