Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated keyword in distutils metadata #70277

Closed
AugustinLaville mannequin opened this issue Jan 12, 2016 · 4 comments
Closed

Duplicated keyword in distutils metadata #70277

AugustinLaville mannequin opened this issue Jan 12, 2016 · 4 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@AugustinLaville
Copy link
Mannequin

AugustinLaville mannequin commented Jan 12, 2016

BPO 26089
Nosy @ezio-melotti, @merwok, @berkerpeksag, @dstufft
Files
  • issue26089.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2016-04-23.22:59:29.865>
    created_at = <Date 2016-01-12.09:44:50.027>
    labels = ['type-feature', 'library']
    title = 'Duplicated keyword in distutils metadata'
    updated_at = <Date 2016-04-23.22:59:29.863>
    user = 'https://bugs.python.org/AugustinLaville'

    bugs.python.org fields:

    activity = <Date 2016-04-23.22:59:29.863>
    actor = 'berker.peksag'
    assignee = 'none'
    closed = True
    closed_date = <Date 2016-04-23.22:59:29.865>
    closer = 'berker.peksag'
    components = ['Distutils']
    creation = <Date 2016-01-12.09:44:50.027>
    creator = 'Augustin Laville'
    dependencies = []
    files = ['41591']
    hgrepos = []
    issue_num = 26089
    keywords = ['patch']
    message_count = 4.0
    messages = ['258091', '258093', '264075', '264076']
    nosy_count = 6.0
    nosy_names = ['ezio.melotti', 'eric.araujo', 'python-dev', 'berker.peksag', 'dstufft', 'Augustin Laville']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue26089'
    versions = ['Python 3.6']

    @AugustinLaville
    Copy link
    Mannequin Author

    AugustinLaville mannequin commented Jan 12, 2016

    The line https://hg.python.org/cpython/file/tip/Lib/distutils/dist.py#l1016 contains the word "licence" twice.

    Check only on Python, 3.5 and 3.6, may be in others versions.

    @AugustinLaville AugustinLaville mannequin added performance Performance or resource usage stdlib Python modules in the Lib dir labels Jan 12, 2016
    @ezio-melotti
    Copy link
    Member

    This seems to be because the alternative spelling "licence" was also included in the list, and got changed in bpo-693470/178d19cff163.
    Because of that change, the method get_licence() is not supported anymore, but at this point removing the duplicate "license" should be safe.
    Attached a patch.
    (Note that there seem to be no tests for the "licence" alias in Lib/distutils/tests)

    @ezio-melotti ezio-melotti added type-feature A feature request or enhancement and removed performance Performance or resource usage labels Jan 12, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 23, 2016

    New changeset 21e522177ca0 by Berker Peksag in branch 'default':
    Issue bpo-26089: Remove duplicate field 'license' from DistributionMetadata
    https://hg.python.org/cpython/rev/21e522177ca0

    @berkerpeksag
    Copy link
    Member

    I just committed Ezio's patch. Thanks!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants