Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turtle.fillcolor doesn't accept a tuple of floats #71406

Open
JelleZijlstra opened this issue Jun 4, 2016 · 3 comments
Open

turtle.fillcolor doesn't accept a tuple of floats #71406

JelleZijlstra opened this issue Jun 4, 2016 · 3 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@JelleZijlstra
Copy link
Member

BPO 27219
Nosy @serhiy-storchaka, @JelleZijlstra
Dependencies
  • bpo-21916: Create unit tests for turtle textonly
  • Files
  • issue27219.patch: patch adding support for float color tuples
  • issue27219-cr.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-06-04.16:29:00.290>
    labels = ['type-feature', 'library']
    title = "turtle.fillcolor doesn't accept a tuple of floats"
    updated_at = <Date 2022-01-23.05:20:43.631>
    user = 'https://github.com/JelleZijlstra'

    bugs.python.org fields:

    activity = <Date 2022-01-23.05:20:43.631>
    actor = 'JelleZijlstra'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2016-06-04.16:29:00.290>
    creator = 'JelleZijlstra'
    dependencies = ['21916']
    files = ['43217', '43236']
    hgrepos = []
    issue_num = 27219
    keywords = ['patch']
    message_count = 3.0
    messages = ['267263', '267394', '267423']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'JelleZijlstra']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue27219'
    versions = ['Python 3.6']

    @JelleZijlstra
    Copy link
    Member Author

    But turtle.pencolor() returns a tuple of floats, so calling turtle.fillcolor(turtle.pencolor()). This issue shows up in the doctest at library/turtle.rst line 936. I can submit a patch with tests once the tests in bpo-21916 are in.

    @JelleZijlstra JelleZijlstra self-assigned this Jun 4, 2016
    @JelleZijlstra JelleZijlstra added the stdlib Python modules in the Lib dir label Jun 4, 2016
    @serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Jun 4, 2016
    @serhiy-storchaka
    Copy link
    Member

    _color_triple_to_hexstring() is implementation detail. It would be better to test it indirectly using public method (like fillcolor()). Added other comments on Rietveld.

    @JelleZijlstra
    Copy link
    Member Author

    New patch

    @JelleZijlstra JelleZijlstra removed their assignment Jan 23, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    Status: No status
    Development

    No branches or pull requests

    2 participants