add the 'unix_shell' attribute to test.support

[xdegaye]

BPO	27472
Nosy	@vstinner, @bitdancer, @xdegaye
Dependencies	bpo-27027: add the 'is_android' attribute to test.support
Files	unix_shell_27472.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/xdegaye'
closed_at = <Date 2016-07-22.10:38:17.282>
created_at = <Date 2016-07-09.15:12:35.817>
labels = ['type-bug', 'tests']
title = "add the 'unix_shell' attribute to test.support"
updated_at = <Date 2016-07-22.10:38:17.281>
user = 'https://github.com/xdegaye'

bugs.python.org fields:

activity = <Date 2016-07-22.10:38:17.281>
actor = 'xdegaye'
assignee = 'xdegaye'
closed = True
closed_date = <Date 2016-07-22.10:38:17.282>
closer = 'xdegaye'
components = ['Tests']
creation = <Date 2016-07-09.15:12:35.817>
creator = 'xdegaye'
dependencies = ['27027']
files = ['43687']
hgrepos = []
issue_num = 27472
keywords = ['patch']
message_count = 5.0
messages = ['270044', '270093', '270100', '270168', '270984']
nosy_count = 4.0
nosy_names = ['vstinner', 'r.david.murray', 'xdegaye', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue27472'
versions = ['Python 3.6']

[xdegaye]

'/bin/sh' is hard-coded in few places in the test suite, but the Android shell is at '/system/bin/sh', see msg266084.

[bitdancer]

I think a cross reference to bpo-16353 is worth making here :) I presume your intent with this issue is to avoid having to wait for that issue to get resolved.

[xdegaye]

Yes, bpo-27027 adds test.support.is_android and there is no need now to wait for bpo-16353. Thanks David for reminding me, I have just added a cross-reference to bpo-16353.

[xdegaye]

The attached patch ignores the following test modules listed in msg266084:

Lib/distutils/tests/test_build_scripts.py|68 col 31| ("#!/bin/sh\n"
Lib/distutils/tests/test_install_scripts.py|57 col 38| write_script("shell.sh", ("#!/bin/sh\n"
reason:
The scripts are not meant to be run.

Lib/test/test__osx_support.py|46 col 24| f.write("#!/bin/sh\n/bin/echo OK\n")
Lib/test/test__osx_support.py|58 col 24| f.write("#!/bin/sh\n/bin/echo ExpectedOutput\n")
Lib/test/test__osx_support.py|149 col 28| f.write("#!/bin/sh\n/bin/echo " + c_output)
Lib/test/test__osx_support.py|205 col 24| f.write("#!/bin/sh\nexit 255")
reason:
These tests run only on the darwin platform.

Lib/test/test_subprocess.py|1645 col 15| sh = '/bin/sh'
Lib/test/test_subprocess.py|1647 col 33| # Test will fail if /bin/sh is a symlink to csh.
reason:
This test is specific to bash or ksh.

[python-dev]

New changeset 15835311b5e6 by Xavier de Gaye in branch 'default':
Issue bpo-27472: Add test.support.unix_shell as the path to the default shell.
https://hg.python.org/cpython/rev/15835311b5e6