Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the 'unix_shell' attribute to test.support #71659

Closed
xdegaye mannequin opened this issue Jul 9, 2016 · 5 comments
Closed

add the 'unix_shell' attribute to test.support #71659

xdegaye mannequin opened this issue Jul 9, 2016 · 5 comments
Assignees
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@xdegaye
Copy link
Mannequin

xdegaye mannequin commented Jul 9, 2016

BPO 27472
Nosy @vstinner, @bitdancer, @xdegaye
Dependencies
  • bpo-27027: add the 'is_android' attribute to test.support
  • Files
  • unix_shell_27472.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/xdegaye'
    closed_at = <Date 2016-07-22.10:38:17.282>
    created_at = <Date 2016-07-09.15:12:35.817>
    labels = ['type-bug', 'tests']
    title = "add the 'unix_shell' attribute to test.support"
    updated_at = <Date 2016-07-22.10:38:17.281>
    user = 'https://github.com/xdegaye'

    bugs.python.org fields:

    activity = <Date 2016-07-22.10:38:17.281>
    actor = 'xdegaye'
    assignee = 'xdegaye'
    closed = True
    closed_date = <Date 2016-07-22.10:38:17.282>
    closer = 'xdegaye'
    components = ['Tests']
    creation = <Date 2016-07-09.15:12:35.817>
    creator = 'xdegaye'
    dependencies = ['27027']
    files = ['43687']
    hgrepos = []
    issue_num = 27472
    keywords = ['patch']
    message_count = 5.0
    messages = ['270044', '270093', '270100', '270168', '270984']
    nosy_count = 4.0
    nosy_names = ['vstinner', 'r.david.murray', 'xdegaye', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue27472'
    versions = ['Python 3.6']

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Jul 9, 2016

    '/bin/sh' is hard-coded in few places in the test suite, but the Android shell is at '/system/bin/sh', see msg266084.

    @xdegaye xdegaye mannequin self-assigned this Jul 9, 2016
    @xdegaye xdegaye mannequin added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Jul 9, 2016
    @bitdancer
    Copy link
    Member

    bitdancer commented Jul 10, 2016

    I think a cross reference to bpo-16353 is worth making here :) I presume your intent with this issue is to avoid having to wait for that issue to get resolved.

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Jul 10, 2016

    Yes, bpo-27027 adds test.support.is_android and there is no need now to wait for bpo-16353. Thanks David for reminding me, I have just added a cross-reference to bpo-16353.

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Jul 11, 2016

    The attached patch ignores the following test modules listed in msg266084:

    Lib/distutils/tests/test_build_scripts.py|68 col 31| ("#!/bin/sh\n"
    Lib/distutils/tests/test_install_scripts.py|57 col 38| write_script("shell.sh", ("#!/bin/sh\n"
    reason:
    The scripts are not meant to be run.

    Lib/test/test__osx_support.py|46 col 24| f.write("#!/bin/sh\n/bin/echo OK\n")
    Lib/test/test__osx_support.py|58 col 24| f.write("#!/bin/sh\n/bin/echo ExpectedOutput\n")
    Lib/test/test__osx_support.py|149 col 28| f.write("#!/bin/sh\n/bin/echo " + c_output)
    Lib/test/test__osx_support.py|205 col 24| f.write("#!/bin/sh\nexit 255")
    reason:
    These tests run only on the darwin platform.

    Lib/test/test_subprocess.py|1645 col 15| sh = '/bin/sh'
    Lib/test/test_subprocess.py|1647 col 33| # Test will fail if /bin/sh is a symlink to csh.
    reason:
    This test is specific to bash or ksh.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 22, 2016

    New changeset 15835311b5e6 by Xavier de Gaye in branch 'default':
    Issue bpo-27472: Add test.support.unix_shell as the path to the default shell.
    https://hg.python.org/cpython/rev/15835311b5e6

    @xdegaye xdegaye mannequin closed this as completed Jul 22, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant