asyncio: Document that TCP_NODELAY is now used by default

[1st1]

BPO	28089
Nosy	@gvanrossum, @vstinner, @ned-deily, @berkerpeksag, @1st1, @Mariatta
Files	issue28089.patch issue28089v2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-12-12.21:46:32.516>
created_at = <Date 2016-09-12.01:33:48.169>
labels = ['easy', 'type-feature', '3.7', 'docs', 'expert-asyncio']
title = 'asyncio: Document that TCP_NODELAY is now used by default'
updated_at = <Date 2016-12-16.07:54:15.332>
user = 'https://github.com/1st1'

bugs.python.org fields:

activity = <Date 2016-12-16.07:54:15.332>
actor = 'ned.deily'
assignee = 'docs@python'
closed = True
closed_date = <Date 2016-12-12.21:46:32.516>
closer = 'yselivanov'
components = ['Documentation', 'asyncio']
creation = <Date 2016-09-12.01:33:48.169>
creator = 'yselivanov'
dependencies = []
files = ['45770', '45772']
hgrepos = []
issue_num = 28089
keywords = ['patch', 'easy']
message_count = 14.0
messages = ['282459', '282466', '282470', '282471', '282495', '282497', '282498', '282510', '282511', '283050', '283053', '283054', '283377', '283384']
nosy_count = 8.0
nosy_names = ['gvanrossum', 'vstinner', 'ned.deily', 'docs@python', 'python-dev', 'berker.peksag', 'yselivanov', 'Mariatta']
pr_nums = []
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue28089'
versions = ['Python 3.6', 'Python 3.7']

[ned-deily]

This is marked as a release blocker but, since it's just a doc change, I'm not going to hold 3.6.0 for it. It would be nice to get it in, though.

[vstinner]

Yury: I don't understand your issue, can you please elaborate? Do you mean that the default value of the TCP_NODELAY changed in Python 3.6? Otherwise, why do you consider it as a release blocker?

The Python 3.6 release must be blocked by a TCP flag? Really?

[Mariatta]

The change is that TCP_NODELAY option is set by default in 3.6. It was not the case in 3.5.

[vstinner]

The change is that TCP_NODELAY option is set by default in 3.6. It was not the case in 3.5.

Ah, it's a change in _asyncio_, ok. I missed that from the issue title, so I changed the title.

[Mariatta]

I added the following to Doc/library/asyncio-protocol.rst

.. versionchanged:: 3.6.0
The socket option TCP_NODELAY is now set by default.

Let me know if this patch works.

[berkerpeksag]

+.. versionchanged:: 3.6.0

3.6.0 -> 3.6

+ The socket option TCP_NODELAY is now set by default.

TCP_NODELAY -> TCP_NODELAY

[Mariatta]

Thanks, Berker :)
Updated.

[python-dev]

New changeset 726308cfe3b5 by Victor Stinner in branch '3.6':
catch_warnings() calls showwarning() if overriden
https://hg.python.org/cpython/rev/726308cfe3b5

[python-dev]

New changeset 150d36dbe3ba by Victor Stinner in branch '3.6':
warnings: Fix the issue number
https://hg.python.org/cpython/rev/150d36dbe3ba

[ned-deily]

Yury, look good to you?

[python-dev]

New changeset 853e3f4d6cd9 by Yury Selivanov in branch '3.6':
Issue bpo-28089: Document TCP_NODELAY in asyncio
https://hg.python.org/cpython/rev/853e3f4d6cd9

New changeset 0d209cc7ffdc by Yury Selivanov in branch 'default':
Merge 3.6 (issue bpo-28089)
https://hg.python.org/cpython/rev/0d209cc7ffdc

[1st1]

Yury, look good to you?

Yes; committed the patch with a small addition. Thanks, Mariatta!

[python-dev]

New changeset dfd1019f75f9 by Yury Selivanov in branch '3.6':
Issue bpo-28089: Document TCP_NODELAY in asyncio
https://hg.python.org/cpython/rev/dfd1019f75f9

[ned-deily]

[cherrypicked for 3.6.0rc2]