Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for typing module #72574

Closed
ilevkivskyi opened this issue Oct 7, 2016 · 4 comments
Closed

Update documentation for typing module #72574

ilevkivskyi opened this issue Oct 7, 2016 · 4 comments
Labels
docs Documentation in the Doc dir

Comments

@ilevkivskyi
Copy link
Member

BPO 28388
Nosy @gvanrossum, @ilevkivskyi
Files
  • doc-typing-patch.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2016-10-09.03:10:59.279>
    created_at = <Date 2016-10-07.23:56:50.798>
    labels = ['docs']
    title = 'Update documentation for typing module'
    updated_at = <Date 2016-10-09.03:14:13.446>
    user = 'https://github.com/ilevkivskyi'

    bugs.python.org fields:

    activity = <Date 2016-10-09.03:14:13.446>
    actor = 'python-dev'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2016-10-09.03:10:59.279>
    closer = 'gvanrossum'
    components = ['Documentation']
    creation = <Date 2016-10-07.23:56:50.798>
    creator = 'levkivskyi'
    dependencies = []
    files = ['45007']
    hgrepos = []
    issue_num = 28388
    keywords = ['patch']
    message_count = 4.0
    messages = ['278283', '278332', '278335', '278336']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'docs@python', 'python-dev', 'levkivskyi']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue28388'
    versions = ['Python 3.5', 'Python 3.6']

    @ilevkivskyi
    Copy link
    Member Author

    Here is the patch with updates according to recent changes in typing module and PEP-484:

    • most things are not classes now
    • outcome of parameterizing generics is cached
    • Union does not unify everything with Any
    • few minor fixes

    This patch also fixes http://bugs.python.org/issue27588

    The attached patch is generated for 3.5

    @ilevkivskyi ilevkivskyi added the docs Documentation in the Doc dir label Oct 7, 2016
    @gvanrossum
    Copy link
    Member

    LGTM. I have a small number of nits that I will apply when merging this.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 9, 2016

    New changeset 9953efbb4974 by Guido van Rossum in branch '3.5':
    Issue bpo-28388: update typing module documentation.
    https://hg.python.org/cpython/rev/9953efbb4974

    New changeset 589e11c3489e by Guido van Rossum in branch '3.6':
    Issue bpo-28388: update typing module documentation. (merge 3.5->3.6)
    https://hg.python.org/cpython/rev/589e11c3489e

    New changeset 6cb9dfe4cbeb by Guido van Rossum in branch 'default':
    Issue bpo-28388: update typing module documentation. (merge 3.6->3.7)
    https://hg.python.org/cpython/rev/6cb9dfe4cbeb

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 9, 2016

    New changeset d7f2b0332343 by Guido van Rossum in branch '3.5':
    Adjust ClassVar example to use pre-PEP-526 syntax. (Issue bpo-28388)
    https://hg.python.org/cpython/rev/d7f2b0332343

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants