Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong link in pkgutil.get_data doc #72624

Closed
zhangyangyu opened this issue Oct 14, 2016 · 4 comments
Closed

Wrong link in pkgutil.get_data doc #72624

zhangyangyu opened this issue Oct 14, 2016 · 4 comments
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@zhangyangyu
Copy link
Member

BPO 28438
Nosy @orsenthil, @zhangyangyu
Files
  • pkgutil.get_data_doc.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2016-10-14.06:01:17.639>
    created_at = <Date 2016-10-14.04:14:26.072>
    labels = ['type-bug', '3.7', 'docs']
    title = 'Wrong link in pkgutil.get_data doc'
    updated_at = <Date 2016-10-14.06:02:17.734>
    user = 'https://github.com/zhangyangyu'

    bugs.python.org fields:

    activity = <Date 2016-10-14.06:02:17.734>
    actor = 'xiang.zhang'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2016-10-14.06:01:17.639>
    closer = 'orsenthil'
    components = ['Documentation']
    creation = <Date 2016-10-14.04:14:26.072>
    creator = 'xiang.zhang'
    dependencies = []
    files = ['45087']
    hgrepos = []
    issue_num = 28438
    keywords = ['patch']
    message_count = 4.0
    messages = ['278631', '278634', '278635', '278636']
    nosy_count = 4.0
    nosy_names = ['orsenthil', 'docs@python', 'python-dev', 'xiang.zhang']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue28438'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    @zhangyangyu
    Copy link
    Member Author

    The get_data link in pkgutil.get_data doc refers to itself which does not help reading. I think it's better for it to refer to importlib.abc.ResourceLoader.get_data.

    @zhangyangyu zhangyangyu added the 3.7 (EOL) end of life label Oct 14, 2016
    @zhangyangyu zhangyangyu added the docs Documentation in the Doc dir label Oct 14, 2016
    @orsenthil
    Copy link
    Member

    The patch looks good to me. Thank you, Xiang. I will apply it.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 14, 2016

    New changeset 7fb90c4ae643 by Senthil Kumaran in branch '3.5':
    bpo-28438 - Fix the link for pkgutil.get_data doc. Patch contributed by Xiang Zhang.
    https://hg.python.org/cpython/rev/7fb90c4ae643

    New changeset f2110f41012e by Senthil Kumaran in branch '3.6':
    [merge from 3.5] bpo-28438 - Fix the link for pkgutil.get_data doc.
    https://hg.python.org/cpython/rev/f2110f41012e

    New changeset 897fe8fa14b5 by Senthil Kumaran in branch 'default':
    [merge from 3.6] bpo-28438 - Fix the link for pkgutil.get_data doc.
    https://hg.python.org/cpython/rev/897fe8fa14b5

    @orsenthil orsenthil added the type-bug An unexpected behavior, bug, or error label Oct 14, 2016
    @zhangyangyu
    Copy link
    Member Author

    Thanks Senthil.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants