Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant checks in PyUnicode_EncodeLocale and PyUnicode_DecodeLocaleAndSize #72625

Closed
zhangyangyu opened this issue Oct 14, 2016 · 3 comments
Assignees
Labels
3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@zhangyangyu
Copy link
Member

BPO 28439
Nosy @vstinner, @serhiy-storchaka, @zhangyangyu
Files
  • issue28349.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2016-10-23.12:42:54.663>
    created_at = <Date 2016-10-14.09:28:47.982>
    labels = ['interpreter-core', 'type-feature', '3.7']
    title = 'Remove redundant checks in PyUnicode_EncodeLocale and PyUnicode_DecodeLocaleAndSize'
    updated_at = <Date 2016-10-23.12:42:54.663>
    user = 'https://github.com/zhangyangyu'

    bugs.python.org fields:

    activity = <Date 2016-10-23.12:42:54.663>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2016-10-23.12:42:54.663>
    closer = 'serhiy.storchaka'
    components = ['Interpreter Core']
    creation = <Date 2016-10-14.09:28:47.982>
    creator = 'xiang.zhang'
    dependencies = []
    files = ['45118']
    hgrepos = []
    issue_num = 28439
    keywords = ['patch']
    message_count = 3.0
    messages = ['279138', '279143', '279257']
    nosy_count = 4.0
    nosy_names = ['vstinner', 'python-dev', 'serhiy.storchaka', 'xiang.zhang']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue28439'
    versions = ['Python 3.7']

    @zhangyangyu zhangyangyu added 3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Oct 14, 2016
    @zhangyangyu zhangyangyu changed the title Remove redundant checks in PyUnicode_EncodeLocale Remove redundant checks in PyUnicode_EncodeLocale and PyUnicode_DecodeLocaleAndSize Oct 16, 2016
    @serhiy-storchaka serhiy-storchaka self-assigned this Oct 21, 2016
    @serhiy-storchaka
    Copy link
    Member

    Added comments on Rietveld.

    Xiang, seem you have provided wrong e-mail address for Rietveld. I constantly get error messages "Undelivered Mail Returned to Sender" after pushing comments to patches that your are following. I suppose you don't receive Rietveld notifications.

    @zhangyangyu
    Copy link
    Member Author

    Thanks for your review Serhiy.

    I don't receive the notification. :-( Honestly speaking I miss some notification emails from time to time, but not all. I'll consider choosing another ISP. I have to manually check the Rietveld now to avoid missing any comments.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 23, 2016

    New changeset 94d34354bef1 by Serhiy Storchaka in branch 'default':
    Issue bpo-28439: Remove redundant checks in PyUnicode_EncodeLocale and
    https://hg.python.org/cpython/rev/94d34354bef1

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants