Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _asyncio._init_module function #72638

Closed
methane opened this issue Oct 15, 2016 · 3 comments
Closed

Remove _asyncio._init_module function #72638

methane opened this issue Oct 15, 2016 · 3 comments
Labels
3.7 (EOL) end of life topic-asyncio type-feature A feature request or enhancement

Comments

@methane
Copy link
Member

methane commented Oct 15, 2016

BPO 28452
Nosy @gvanrossum, @methane, @1st1
Files
  • asyncio-speedup-refactoring.patch
  • asyncio-speedup-refactoring2.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2016-10-18.02:49:19.065>
    created_at = <Date 2016-10-15.20:13:30.658>
    labels = ['type-feature', '3.7', 'expert-asyncio']
    title = 'Remove _asyncio._init_module function'
    updated_at = <Date 2016-10-18.02:49:19.064>
    user = 'https://github.com/methane'

    bugs.python.org fields:

    activity = <Date 2016-10-18.02:49:19.064>
    actor = 'methane'
    assignee = 'none'
    closed = True
    closed_date = <Date 2016-10-18.02:49:19.065>
    closer = 'methane'
    components = ['asyncio']
    creation = <Date 2016-10-15.20:13:30.658>
    creator = 'methane'
    dependencies = []
    files = ['45104', '45122']
    hgrepos = []
    issue_num = 28452
    keywords = ['patch']
    message_count = 3.0
    messages = ['278731', '278828', '278834']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'methane', 'python-dev', 'yselivanov']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue28452'
    versions = ['Python 3.6', 'Python 3.7']

    @methane
    Copy link
    Member Author

    methane commented Oct 15, 2016

    _asyncio._init_module() looks ugly.
    This patch imports external dependency when importing _asyncio.

    @methane methane added 3.7 (EOL) end of life topic-asyncio type-feature A feature request or enhancement labels Oct 15, 2016
    @1st1
    Copy link
    Member

    1st1 commented Oct 17, 2016

    LGTM

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 18, 2016

    New changeset d32ec6591c49 by INADA Naoki in branch '3.6':
    Issue bpo-28452: Remove _asyncio._init_module function
    https://hg.python.org/cpython/rev/d32ec6591c49

    New changeset ce85a1f129e3 by INADA Naoki in branch 'default':
    Issue bpo-28452: Remove _asyncio._init_module function
    https://hg.python.org/cpython/rev/ce85a1f129e3

    @methane methane closed this as completed Oct 18, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life topic-asyncio type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants